LayoutTests/fast/events/script-tests/init-events.js - Issue 1232403003: Removing UIEvent.keyCode and charCode.

Unified Diff: LayoutTests/fast/events/script-tests/init-events.js

Issue 1232403003: Removing UIEvent.keyCode and charCode. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/events/init-events-expected.txt ('k') | LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt » ('j') | Source/core/events/UIEvent.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/events/script-tests/init-events.js

diff --git a/LayoutTests/fast/events/script-tests/init-events.js b/LayoutTests/fast/events/script-tests/init-events.js

index df709989974dff667a0d4159d63f54314ac52470..d75e5f94b8cd9e9d9b148e06ac25668c6e45699a 100644

--- a/LayoutTests/fast/events/script-tests/init-events.js

+++ b/LayoutTests/fast/events/script-tests/init-events.js

@@ -100,8 +100,8 @@ shouldBe("testInitEvent('Mouse', '\"a\", false, false, window, 1001, 1002, 1003,

shouldBe("testInitEvent('Mouse', '\"a\", false, false, window, 1001, 1002, 1003, 1004, 1005, false, false, false, false, 1006, document').fromElement", "document");

shouldBe("testInitEvent('Mouse', '\"a\", false, false, window, 1001, 1002, 1003, 1004, 1005, false, false, false, false, 1006, null').toElement", "null");

shouldBe("testInitEvent('Mouse', '\"a\", false, false, window, 1001, 1002, 1003, 1004, 1005, false, false, false, false, 1006, null').dataTransfer", "null");

-shouldBe("testInitEvent('Mouse', '\"a\", false, false, window, 1001, 1002, 1003, 1004, 1005, false, false, false, false, 1006, null').keyCode", "0");

-shouldBe("testInitEvent('Mouse', '\"a\", false, false, window, 1001, 1002, 1003, 1004, 1005, false, false, false, false, 1006, null').charCode", "0");

+shouldBe("testInitEvent('Mouse', '\"a\", false, false, window, 1001, 1002, 1003, 1004, 1005, false, false, false, false, 1006, null').keyCode", "undefined");

philipj_slow 2015/07/13 13:58:59 There are tests for KeyboardEvent in this file to,

+shouldBe("testInitEvent('Mouse', '\"a\", false, false, window, 1001, 1002, 1003, 1004, 1005, false, false, false, false, 1006, null').charCode", "undefined");

shouldBe("testInitEvent('Mouse', '\"a\", false, false, window, 1001, 1002, 1003, 1004, 1005, false, false, false, false, 1006, null').layerX", "1004");

shouldBe("testInitEvent('Mouse', '\"a\", false, false, window, 1001, 1002, 1003, 1004, 1005, false, false, false, false, 1006, null').layerY", "1005");

shouldBe("testInitEvent('Mouse', '\"a\", false, false, window, 1001, 1002, 1003, 1004, 1005, false, false, false, false, 1006, null').pageX", "1004");

@@ -150,8 +150,8 @@ shouldBe("testInitEvent('Text', '\"a\", false, false, null, \"b\"').view", "null

shouldBe("testInitEvent('Text', '\"a\", false, false, window, \"b\"').data", "'b'");

shouldBe("testInitEvent('Text', '\"a\", false, false, window, null').data", "'null'");

shouldBe("testInitEvent('Text', '\"a\", false, false, window, \"b\"').detail", "0");

-shouldBe("testInitEvent('Text', '\"a\", false, false, window, \"b\"').keyCode", "0");

-shouldBe("testInitEvent('Text', '\"a\", false, false, window, \"b\"').charCode", "0");

+shouldBe("testInitEvent('Text', '\"a\", false, false, window, \"b\"').keyCode", "undefined");

+shouldBe("testInitEvent('Text', '\"a\", false, false, window, \"b\"').charCode", "undefined");

shouldBe("testInitEvent('Text', '\"a\", false, false, window, \"b\"').which", "0");

shouldBe("testInitEvent('UI', '\"a\", false, false, window, 1001').type", "'a'");

@@ -163,8 +163,8 @@ shouldBe("testInitEvent('UI', '\"a\", false, true, window, 1001').cancelable", "

shouldBe("testInitEvent('UI', '\"a\", false, false, window, 1001').view", "window");

shouldBe("testInitEvent('UI', '\"a\", false, false, null, 1001').view", "null");

shouldBe("testInitEvent('UI', '\"a\", false, false, window, 1001').detail", "1001");

-shouldBe("testInitEvent('UI', '\"a\", false, false, window, 1001').keyCode", "0");

-shouldBe("testInitEvent('UI', '\"a\", false, false, window, 1001').charCode", "0");

+shouldBe("testInitEvent('UI', '\"a\", false, false, window, 1001').keyCode", "undefined");

+shouldBe("testInitEvent('UI', '\"a\", false, false, window, 1001').charCode", "undefined");

shouldBe("testInitEvent('UI', '\"a\", false, false, window, 1001').which", "0");

// WheelEvent has no init function yet; roughly speaking, we are waiting for that part of DOM 3 to stabilize.