Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 12324011: Merge 142594 (Closed)

Created:
7 years, 9 months ago by yurys
Modified:
7 years, 9 months ago
Reviewers:
yurys
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 142594 > Web Inspector: stack trace is cut at native bind if inspector is closed > https://bugs.webkit.org/show_bug.cgi?id=109427 > > Reviewed by Pavel Feldman. > > Source/WebCore: > > Only top frame is collected instead of full stack trace when inspector > front-end is closed to avoid expensive operations when exceptions are > thrown. > > Test: http/tests/inspector-enabled/console-exception-while-no-inspector.html > > * inspector/InspectorConsoleAgent.cpp: > (WebCore::InspectorConsoleAgent::addMessageToConsole): > > LayoutTests: > > Test that stack trace for uncaught exceptions is collected when inspector > front-end is closed. > > * http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Added. > * http/tests/inspector-enabled/console-exception-while-no-inspector.html: Added. > * platform/chromium/http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Added. TBR=yurys@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143459

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, --1 lines) Patch
A + LayoutTests/http/tests/inspector-enabled/console-exception-while-no-inspector.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/inspector/InspectorConsoleAgent.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
yurys
7 years, 9 months ago (2013-02-20 14:37:05 UTC) #1
yurys
7 years, 9 months ago (2013-02-20 14:37:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r143459.

Powered by Google App Engine
This is Rietveld 408576698