Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 12324009: Remove PrefService parameter from chrome::RegisterPrefs. (Closed)

Created:
7 years, 10 months ago by Jói
Modified:
7 years, 10 months ago
CC:
chromium-reviews, MAD, Ilya Sherman, jar (doing other things), sail+watch_chromium.org
Visibility:
Public.

Description

Remove PrefService parameter from chrome::RegisterPrefs. TBR=ben@chromium.org BUG=155525 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183812

Patch Set 1 #

Patch Set 2 : Merge LKGR #

Patch Set 3 : Merge to head for commit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -24 lines) Patch
M chrome/browser/browser_process_impl.cc View 1 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/metrics/metrics_log_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud_policy_core_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/device_cloud_policy_manager_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_statistics_collector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/user_cloud_policy_manager_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/user_policy_signin_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/scoped_testing_local_state.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Jói
7 years, 10 months ago (2013-02-20 13:02:04 UTC) #1
Mattias Nissler (ping if slow)
Excellent, LGTM!
7 years, 10 months ago (2013-02-20 13:03:58 UTC) #2
Jói
TBR=ben@chromium.org for trivial usage update (drop a parameter) in code that needs OWNERS approval. Cheers, ...
7 years, 10 months ago (2013-02-21 14:49:44 UTC) #3
Jói
Committed patchset #3 manually as r183812 (presubmit successful).
7 years, 10 months ago (2013-02-21 14:51:10 UTC) #4
Ben Goodger (Google)
7 years, 10 months ago (2013-02-22 00:47:58 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698