Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: Source/core/inspector/InjectedScriptSource.js

Issue 1232393003: Return an array from bling-bling (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated tests to reflect API modifcation Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/inspector/console/command-line-api-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InjectedScriptSource.js
diff --git a/Source/core/inspector/InjectedScriptSource.js b/Source/core/inspector/InjectedScriptSource.js
index 2d831832586021d5c6abc50ad7fed88285ea7ab7..68be2f41542ab91b855c9a55f0ea2a72067bc13f 100644
--- a/Source/core/inspector/InjectedScriptSource.js
+++ b/Source/core/inspector/InjectedScriptSource.js
@@ -1785,8 +1785,8 @@ CommandLineAPIImpl.prototype = {
$$: function (selector, opt_startNode)
{
if (this._canQuerySelectorOnNode(opt_startNode))
- return opt_startNode.querySelectorAll(selector);
- return inspectedGlobalObject.document.querySelectorAll(selector);
+ return Array.from(opt_startNode.querySelectorAll(selector));
pfeldman 2015/07/14 11:47:22 We should instead use local implementation of slic
yurys 2015/07/14 12:50:44 My first reaction was the same but then I realized
+ return Array.from(inspectedGlobalObject.document.querySelectorAll(selector));
},
/**
« no previous file with comments | « LayoutTests/inspector/console/command-line-api-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698