Return an array from bling-bling

Source/core/inspector/InjectedScriptSource.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 1767 matching lines @@
     },
 
     /**
      * @param {string} selector
      * @param {!Node=} opt_startNode
      * @return {*}
      */
     $$: function (selector, opt_startNode)
     {
         if (this._canQuerySelectorOnNode(opt_startNode))
-            return opt_startNode.querySelectorAll(selector);
-        return inspectedGlobalObject.document.querySelectorAll(selector);
+            return Array.from(opt_startNode.querySelectorAll(selector));

[pfeldman, 2015/07/14 11:47:22]

We should instead use local implementation of slice() so that this code was
immune to the re-definition of Array.from 

[yurys, 2015/07/14 12:50:44]

My first reaction was the same but then I realized that we call querySelectorAll
which may well me overwritten by the user so fixing just Array.from would add
much without finding a way to call original querySelectorAll.

+        return Array.from(inspectedGlobalObject.document.querySelectorAll(selector));
     },
 
     /**
      * @param {!Node=} node
      * @return {boolean}
      */
     _canQuerySelectorOnNode: function(node)
     {
         return !!node && InjectedScriptHost.subtype(node) === "node" && (node.nodeType === Node.ELEMENT_NODE || node.nodeType === Node.DOCUMENT_NODE || node.nodeType === Node.DOCUMENT_FRAGMENT_NODE);
     },
@@ skipping 227 matching lines @@
      */
     _logEvent: function(event)
     {
         inspectedGlobalObject.console.log(event.type, event);
     }
 }
 
 injectedScript._commandLineAPIImpl = new CommandLineAPIImpl();
 return injectedScript;
 })