Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1232393003: Return an array from bling-bling (Closed)

Created:
5 years, 5 months ago by Jonathan Garbee
Modified:
5 years, 5 months ago
Reviewers:
yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Return an array from bling-bling BUG=507518 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198879

Patch Set 1 #

Patch Set 2 : Updated tests to reflect API modifcation #

Total comments: 2

Patch Set 3 : Fix the test execution #

Patch Set 4 : Convert from Array.from to slice #

Patch Set 5 : Edit last commit message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M LayoutTests/inspector/console/command-line-api.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/console/command-line-api-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InjectedScriptSource.js View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
yurys
lgtm
5 years, 5 months ago (2015-07-14 09:34:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232393003/20001
5 years, 5 months ago (2015-07-14 09:34:30 UTC) #4
commit-bot: I haz the power
The author jonathan.garbee@chromium.org has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-14 09:34:33 UTC) #5
commit-bot: I haz the power
The author jonathan.garbee@chromium.org has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-14 10:01:50 UTC) #6
pfeldman
https://codereview.chromium.org/1232393003/diff/20001/Source/core/inspector/InjectedScriptSource.js File Source/core/inspector/InjectedScriptSource.js (right): https://codereview.chromium.org/1232393003/diff/20001/Source/core/inspector/InjectedScriptSource.js#newcode1788 Source/core/inspector/InjectedScriptSource.js:1788: return Array.from(opt_startNode.querySelectorAll(selector)); We should instead use local implementation of ...
5 years, 5 months ago (2015-07-14 11:47:23 UTC) #9
yurys
https://codereview.chromium.org/1232393003/diff/20001/Source/core/inspector/InjectedScriptSource.js File Source/core/inspector/InjectedScriptSource.js (right): https://codereview.chromium.org/1232393003/diff/20001/Source/core/inspector/InjectedScriptSource.js#newcode1788 Source/core/inspector/InjectedScriptSource.js:1788: return Array.from(opt_startNode.querySelectorAll(selector)); On 2015/07/14 11:47:22, pfeldman wrote: > We ...
5 years, 5 months ago (2015-07-14 12:50:45 UTC) #10
Jonathan Garbee
Just changed to using the internal slice method. I think the fewer things that can ...
5 years, 5 months ago (2015-07-14 16:44:57 UTC) #11
yurys
lgtm
5 years, 5 months ago (2015-07-14 16:51:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232393003/80001
5 years, 5 months ago (2015-07-14 16:55:13 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 18:04:31 UTC) #15
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198879

Powered by Google App Engine
This is Rietveld 408576698