components: Fix 'gn check' errors for omnibox.

components: Fix 'gn check' errors for omnibox.

Tested on Linux with the following command lines:

$ gn gen out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1'
$ gn check out-gn/Release //components/omnibox/*

BUG=367595, 376000
TEST=see above
R=brettw@chromium.org,pkasting@chromium.org,skuhne@chromium.org
TBR=brettw@chromium.org

Committed: https://crrev.com/fc240d37b0b23e1284ed943ea2a0830464190e20
Cr-Commit-Position: refs/heads/master@{#339156}

[tfarina, 2015-07-13 20:34:58]

.gn -> brettw
omnibox -> pkasting
sessions -> skuhne

[Peter Kasting, 2015-07-13 20:59:31]

RS LGTM

[Mr4D (OOO till 08-26), 2015-07-15 16:30:54]

lgtm

[tfarina, 2015-07-16 21:04:08]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-07-16 21:04:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, skuhne@chromium.org
Link to the patchset: https://codereview.chromium.org/1232343006/#ps20001
(title: "fix link failure of components_unittests")

[commit-bot: I haz the power, 2015-07-16 21:07:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1232343006/20001

[commit-bot: I haz the power, 2015-07-16 23:01:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-16 23:02:51]

Patchset 2 (id:??) landed as
https://crrev.com/fc240d37b0b23e1284ed943ea2a0830464190e20
Cr-Commit-Position: refs/heads/master@{#339156}

[loyso (OOO), 2015-07-17 02:05:59]

On 2015/07/16 23:02:51, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/fc240d37b0b23e1284ed943ea2a0830464190e20
> Cr-Commit-Position: refs/heads/master@{#339156}

Looks like this change causes Win x64 GN (dbg) build compile failure.

[kelvinp, 2015-07-17 17:13:07]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1240843004/ by kelvinp@chromium.org.

The reason for reverting is: This CL causes the Windows GN build to fail.
Sample failure at
http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/build....

[brettw, 2015-07-17 17:16:44]

I think you actually want to depend on //components/sessions (not "shared").
shared is a source set and it looks like the only reason for it to exist is to
share with iOS (which is confusingly different than the normal concept of
"shared").

Since "sessions" is a component, in a component build it will include shared,
and now you're linking shared again into the browser, which causes duplicate
symbols.

Maybe when we reland we should set "shared" to have visibility only by
"sessions" with a note that external code should always depend on the main
sessions target. THis will prevent other from being bit by this easy mistake.

[tfarina, 2015-07-17 17:21:11]

But that is the problem.

components/sessions/session_id.h is declared in 'shared', not in 'sessions',
components/omnibox/browser/omnibox_log.h includes from
components/sessions/session_id.h, then gn check warns that you should depend on
components/sessions:shared.

Maybe then, session_id.h should be moved to sessions? What a mess!!

[brettw, 2015-07-17 19:51:53]

You can just make shared in a public_deps section to forward the ability to
include files.

[tfarina, 2015-07-20 20:46:57]

On 2015/07/17 19:51:53, brettw wrote:
> You can just make shared in a public_deps section to forward the ability to
> include files.
OK. I will look into that now.