Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: Source/core/workers/WorkerMessagingProxy.h

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/workers/WorkerLocation.h ('k') | Source/core/workers/WorkerNavigator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/workers/WorkerMessagingProxy.h
diff --git a/Source/core/workers/WorkerMessagingProxy.h b/Source/core/workers/WorkerMessagingProxy.h
index 61327867c472b96058231757bfd00c8926241654..c0fab0dd5b659a191015951a4128bacb8585307f 100644
--- a/Source/core/workers/WorkerMessagingProxy.h
+++ b/Source/core/workers/WorkerMessagingProxy.h
@@ -54,11 +54,11 @@ class CORE_EXPORT WorkerMessagingProxy
public:
// Implementations of WorkerGlobalScopeProxy.
// (Only use these methods in the worker object thread.)
- virtual void startWorkerGlobalScope(const KURL& scriptURL, const String& userAgent, const String& sourceCode, WorkerThreadStartMode) override;
- virtual void terminateWorkerGlobalScope() override;
- virtual void postMessageToWorkerGlobalScope(PassRefPtr<SerializedScriptValue>, PassOwnPtr<MessagePortChannelArray>) override;
- virtual bool hasPendingActivity() const override;
- virtual void workerObjectDestroyed() override;
+ void startWorkerGlobalScope(const KURL& scriptURL, const String& userAgent, const String& sourceCode, WorkerThreadStartMode) override;
+ void terminateWorkerGlobalScope() override;
+ void postMessageToWorkerGlobalScope(PassRefPtr<SerializedScriptValue>, PassOwnPtr<MessagePortChannelArray>) override;
+ bool hasPendingActivity() const override;
+ void workerObjectDestroyed() override;
// These methods come from worker context thread via WorkerObjectProxy
// and are called on the worker object thread (e.g. main thread).
@@ -77,7 +77,7 @@ public:
protected:
WorkerMessagingProxy(InProcessWorkerBase*, PassOwnPtrWillBeRawPtr<WorkerClients>);
- virtual ~WorkerMessagingProxy();
+ ~WorkerMessagingProxy() override;
virtual PassRefPtr<WorkerThread> createWorkerThread(double originTime) = 0;
@@ -91,8 +91,8 @@ private:
// WorkerLoaderProxyProvider
// These methods are called on different threads to schedule loading
// requests and to send callbacks back to WorkerGlobalScope.
- virtual void postTaskToLoader(PassOwnPtr<ExecutionContextTask>) override;
- virtual bool postTaskToWorkerGlobalScope(PassOwnPtr<ExecutionContextTask>) override;
+ void postTaskToLoader(PassOwnPtr<ExecutionContextTask>) override;
+ bool postTaskToWorkerGlobalScope(PassOwnPtr<ExecutionContextTask>) override;
RefPtrWillBePersistent<ExecutionContext> m_executionContext;
OwnPtr<WorkerObjectProxy> m_workerObjectProxy;
« no previous file with comments | « Source/core/workers/WorkerLocation.h ('k') | Source/core/workers/WorkerNavigator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698