Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: Source/core/page/EventSource.h

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/CustomContextMenuProvider.h ('k') | Source/core/page/Page.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/EventSource.h
diff --git a/Source/core/page/EventSource.h b/Source/core/page/EventSource.h
index a9eb0a1f0b44607cb572ee7c20b3aa08279c4d8e..582c50c3d58ec27b4ec41989c6a4c13a034bbdf3 100644
--- a/Source/core/page/EventSource.h
+++ b/Source/core/page/EventSource.h
@@ -56,7 +56,7 @@ class EventSource final : public RefCountedGarbageCollectedEventTargetWithInline
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(EventSource);
public:
static EventSource* create(ExecutionContext*, const String& url, const EventSourceInit&, ExceptionState&);
- virtual ~EventSource();
+ ~EventSource() override;
static const unsigned long long defaultReconnectDelay;
@@ -76,8 +76,8 @@ public:
void close();
- virtual const AtomicString& interfaceName() const override;
- virtual ExecutionContext* executionContext() const override;
+ const AtomicString& interfaceName() const override;
+ ExecutionContext* executionContext() const override;
// ActiveDOMObject
//
@@ -85,21 +85,21 @@ public:
// Page::setDefersLoading() and it defers delivery of events from the
// loader, and therefore the methods of this class for receiving
// asynchronous events from the loader won't be invoked.
- virtual void stop() override;
+ void stop() override;
- virtual bool hasPendingActivity() const override;
+ bool hasPendingActivity() const override;
DECLARE_VIRTUAL_TRACE();
private:
EventSource(ExecutionContext*, const KURL&, const EventSourceInit&);
- virtual void didReceiveResponse(unsigned long, const ResourceResponse&, PassOwnPtr<WebDataConsumerHandle>) override;
- virtual void didReceiveData(const char*, unsigned) override;
- virtual void didFinishLoading(unsigned long, double) override;
- virtual void didFail(const ResourceError&) override;
- virtual void didFailAccessControlCheck(const ResourceError&) override;
- virtual void didFailRedirectCheck() override;
+ void didReceiveResponse(unsigned long, const ResourceResponse&, PassOwnPtr<WebDataConsumerHandle>) override;
+ void didReceiveData(const char*, unsigned) override;
+ void didFinishLoading(unsigned long, double) override;
+ void didFail(const ResourceError&) override;
+ void didFailAccessControlCheck(const ResourceError&) override;
+ void didFailRedirectCheck() override;
void scheduleInitialConnect();
void connect();
« no previous file with comments | « Source/core/page/CustomContextMenuProvider.h ('k') | Source/core/page/Page.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698