Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Unified Diff: Source/core/inspector/InspectorHeapProfilerAgent.cpp

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorHeapProfilerAgent.h ('k') | Source/core/inspector/InspectorHistory.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorHeapProfilerAgent.cpp
diff --git a/Source/core/inspector/InspectorHeapProfilerAgent.cpp b/Source/core/inspector/InspectorHeapProfilerAgent.cpp
index 13169ffad825347759018f8d6346943fb2429d2a..b270abaa56a171b72be7e8da999d6d92878dcf81 100644
--- a/Source/core/inspector/InspectorHeapProfilerAgent.cpp
+++ b/Source/core/inspector/InspectorHeapProfilerAgent.cpp
@@ -120,7 +120,7 @@ public:
{
}
- virtual void write(const uint32_t* chunk, const int size) override
+ void write(const uint32_t* chunk, const int size) override
{
ASSERT(chunk);
ASSERT(size > 0);
@@ -207,18 +207,18 @@ void InspectorHeapProfilerAgent::takeHeapSnapshot(ErrorString* errorString, cons
explicit HeapSnapshotProgress(InspectorFrontend::HeapProfiler* frontend)
: m_frontend(frontend)
, m_totalWork(0) { }
- virtual void Start(int totalWork) override
+ void Start(int totalWork) override
{
m_totalWork = totalWork;
}
- virtual void Worked(int workDone) override
+ void Worked(int workDone) override
{
if (m_frontend) {
m_frontend->reportHeapSnapshotProgress(workDone, m_totalWork, 0);
m_frontend->flush();
}
}
- virtual void Done() override
+ void Done() override
{
const bool finished = true;
if (m_frontend) {
@@ -226,7 +226,7 @@ void InspectorHeapProfilerAgent::takeHeapSnapshot(ErrorString* errorString, cons
m_frontend->flush();
}
}
- virtual bool isCanceled() override { return false; }
+ bool isCanceled() override { return false; }
private:
InspectorFrontend::HeapProfiler* m_frontend;
int m_totalWork;
@@ -285,7 +285,7 @@ void InspectorHeapProfilerAgent::getObjectByHeapObjectId(ErrorString* error, con
class InspectableHeapObject final : public InjectedScriptHost::InspectableObject {
public:
explicit InspectableHeapObject(unsigned heapObjectId) : m_heapObjectId(heapObjectId) { }
- virtual ScriptValue get(ScriptState*) override
+ ScriptValue get(ScriptState*) override
{
return ScriptProfiler::objectByHeapObjectId(m_heapObjectId);
}
« no previous file with comments | « Source/core/inspector/InspectorHeapProfilerAgent.h ('k') | Source/core/inspector/InspectorHistory.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698