Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: Source/core/events/EventTarget.h

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/events/EventFactory.h ('k') | Source/core/events/FocusEvent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/EventTarget.h
diff --git a/Source/core/events/EventTarget.h b/Source/core/events/EventTarget.h
index f1f63ad90610f943bf97ca9e5c9e5a91341b8ce1..b9d2b10e743790769bd4c662ff7ce5dda7e50fa0 100644
--- a/Source/core/events/EventTarget.h
+++ b/Source/core/events/EventTarget.h
@@ -170,8 +170,8 @@ private:
class CORE_EXPORT EventTargetWithInlineData : public EventTarget {
protected:
- virtual EventTargetData* eventTargetData() override final { return &m_eventTargetData; }
- virtual EventTargetData& ensureEventTargetData() override final { return m_eventTargetData; }
+ EventTargetData* eventTargetData() final { return &m_eventTargetData; }
+ EventTargetData& ensureEventTargetData() final { return m_eventTargetData; }
private:
EventTargetData m_eventTargetData;
};
@@ -292,8 +292,8 @@ public: \
using baseClass::ref; \
using baseClass::deref; \
private: \
- virtual void refEventTarget() override final { ref(); } \
- virtual void derefEventTarget() override final { deref(); } \
+ void refEventTarget() final { ref(); } \
+ void derefEventTarget() final { deref(); } \
typedef int thisIsHereToForceASemiColonAfterThisEventTargetMacro
#define REFCOUNTED_EVENT_TARGET(baseClass) DEFINE_EVENT_TARGET_REFCOUNTING(RefCounted<baseClass>)
#define REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(baseClass) DEFINE_EVENT_TARGET_REFCOUNTING(RefCountedGarbageCollected<baseClass>)
« no previous file with comments | « Source/core/events/EventFactory.h ('k') | Source/core/events/FocusEvent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698