Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1232313008: Chromecast: shrinks libcast_shell_android target for testability. (Closed)

Created:
5 years, 5 months ago by gunsch
Modified:
5 years, 5 months ago
Reviewers:
lcwu1, slan, halliwell
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: shrinks libcast_shell_android target for testability. Most functionality should be in cast_shell_common target for things like cast_service_unittests to run. R=slan@chromium.org,halliwell@chromium.org BUG=internal b/22465963 Committed: https://crrev.com/9a5896eb318fe22432ca7e87e21268a44f308fc2 Cr-Commit-Position: refs/heads/master@{#339732}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -24 lines) Patch
M chromecast/chromecast.gyp View 8 chunks +39 lines, -24 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
gunsch
5 years, 5 months ago (2015-07-17 22:56:49 UTC) #1
slan
lgtm lgtm, thanks for taking care of this.
5 years, 5 months ago (2015-07-17 23:17:59 UTC) #2
halliwell
On 2015/07/17 23:17:59, slan wrote: > lgtm > > lgtm, thanks for taking care of ...
5 years, 5 months ago (2015-07-18 00:43:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232313008/1
5 years, 5 months ago (2015-07-19 17:41:36 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 5 months ago (2015-07-19 17:41:39 UTC) #7
gunsch
+lcwu1 for committer stamp (stilllllll)
5 years, 5 months ago (2015-07-20 14:40:59 UTC) #9
lcwu1
lgtm
5 years, 5 months ago (2015-07-21 19:35:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232313008/1
5 years, 5 months ago (2015-07-21 20:06:49 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 20:19:46 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 20:21:00 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a5896eb318fe22432ca7e87e21268a44f308fc2
Cr-Commit-Position: refs/heads/master@{#339732}

Powered by Google App Engine
This is Rietveld 408576698