Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1232313004: Add Tracing.requestMemoryDump method to DevTools API (tracing handler) (Closed)

Created:
5 years, 5 months ago by petrcermak
Modified:
5 years, 4 months ago
CC:
chromium-reviews, wfh+watch_chromium.org, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, tracing+reviews_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Tracing.requestMemoryDump method to DevTools API (tracing handler) This method will allow profiling memory tools such as Telemetry to request memory dumps. Proposal: https://docs.google.com/document/d/190-URzSjfsiXNeyke86z85-5ctuqsC_RoX1J1uJTwIQ/edit?usp=sharing Protocol change (Blink side): https://codereview.chromium.org/1235393005/ BUG=505826 Committed: https://crrev.com/e5e034c10e80e5c1338cea0b17ea8cf0516d9908 Cr-Commit-Position: refs/heads/master@{#340680}

Patch Set 1 #

Patch Set 2 : Rebase after stubs landed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M base/trace_event/memory_dump_manager.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/devtools/protocol/tracing_handler.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/tracing_handler.cc View 1 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 20 (9 generated)
petrcermak
On 2015/07/17 12:52:26, petrcermak wrote: > Patchset #1 (id:1) has been deleted This patch was ...
5 years, 5 months ago (2015-07-24 14:37:12 UTC) #2
pfeldman
lgtm
5 years, 5 months ago (2015-07-24 20:55:46 UTC) #4
pfeldman
lgtm, you'll need to follow up with the protocol.json change.
5 years, 5 months ago (2015-07-24 20:56:23 UTC) #5
petrcermak
dsinclair: Could I please get a stamp from you? Primiano is OOO for 2 weeks. ...
5 years, 4 months ago (2015-07-27 10:31:43 UTC) #7
petrcermak
nduca: Could I please get a stamp from you for base/trace_event? Both primiano and dsinclair ...
5 years, 4 months ago (2015-07-27 14:47:58 UTC) #9
Primiano Tucci (use gerrit)
OOO LGTM
5 years, 4 months ago (2015-07-27 17:03:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232313004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1232313004/20001
5 years, 4 months ago (2015-07-27 17:04:58 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/35006)
5 years, 4 months ago (2015-07-27 17:13:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232313004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1232313004/40001
5 years, 4 months ago (2015-07-28 13:16:48 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 4 months ago (2015-07-28 14:22:05 UTC) #19
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 14:22:37 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5e034c10e80e5c1338cea0b17ea8cf0516d9908
Cr-Commit-Position: refs/heads/master@{#340680}

Powered by Google App Engine
This is Rietveld 408576698