Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 1232243002: In Atomics API, convert operands to numbers before calling runtime. (Closed)

Created:
5 years, 5 months ago by binji
Modified:
5 years, 5 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

In Atomics API, convert operands to numbers before calling runtime. R=jarin@chromium.org Committed: https://crrev.com/7f34af65aa1e1ab54e63e04a81772eee021dc6c6 Cr-Commit-Position: refs/heads/master@{#29625}

Patch Set 1 #

Total comments: 2

Patch Set 2 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M src/harmony-atomics.js View 8 chunks +9 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/atomics.js View 1 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
lgtm https://codereview.chromium.org/1232243002/diff/1/test/mjsunit/harmony/atomics.js File test/mjsunit/harmony/atomics.js (right): https://codereview.chromium.org/1232243002/diff/1/test/mjsunit/harmony/atomics.js#newcode166 test/mjsunit/harmony/atomics.js:166: [false, true, undefined].forEach(function(v) { Maybe you should also ...
5 years, 5 months ago (2015-07-13 05:05:55 UTC) #1
binji
https://codereview.chromium.org/1232243002/diff/1/test/mjsunit/harmony/atomics.js File test/mjsunit/harmony/atomics.js (right): https://codereview.chromium.org/1232243002/diff/1/test/mjsunit/harmony/atomics.js#newcode166 test/mjsunit/harmony/atomics.js:166: [false, true, undefined].forEach(function(v) { On 2015/07/13 at 05:05:55, jarin ...
5 years, 5 months ago (2015-07-13 19:29:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232243002/20001
5 years, 5 months ago (2015-07-13 19:29:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-13 20:36:27 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 20:36:49 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7f34af65aa1e1ab54e63e04a81772eee021dc6c6
Cr-Commit-Position: refs/heads/master@{#29625}

Powered by Google App Engine
This is Rietveld 408576698