Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 123223007: Revert "Revert "Revert "Revert of https://codereview.chromium.org/110593003/""" (Closed)

Created:
6 years, 11 months ago by reed1
Modified:
6 years, 11 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert "Revert "Revert "Revert of https://codereview.chromium.org/110593003/""" This reverts commit aaa89649590323fe40f52439d9a9a3376bb3b8ae. BUG= Committed: https://code.google.com/p/skia/source/detail?r=12910

Patch Set 1 #

Patch Set 2 : fix compatibility mode for onLockPixels by pre-nulling colortable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -107 lines) Patch
M include/core/SkBitmapDevice.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/core/SkMallocPixelRef.h View 2 chunks +4 lines, -6 lines 0 comments Download
M include/core/SkPixelRef.h View 5 chunks +39 lines, -18 lines 0 comments Download
M include/gpu/SkGrPixelRef.h View 1 chunk +3 lines, -4 lines 0 comments Download
M include/images/SkImageRef.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkMallocPixelRef.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M src/core/SkPixelRef.cpp View 1 6 chunks +52 lines, -22 lines 0 comments Download
M src/core/SkScaledImageCache.cpp View 4 chunks +12 lines, -11 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 1 chunk +10 lines, -6 lines 0 comments Download
M src/images/SkImageRef.cpp View 3 chunks +10 lines, -7 lines 0 comments Download
M src/images/SkImageRef_ashmem.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/images/SkImageRef_ashmem.cpp View 2 chunks +3 lines, -7 lines 0 comments Download
M src/lazy/SkCachingPixelRef.h View 1 chunk +1 line, -1 line 0 comments Download
M src/lazy/SkCachingPixelRef.cpp View 4 chunks +9 lines, -8 lines 0 comments Download
M src/lazy/SkDiscardablePixelRef.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/lazy/SkDiscardablePixelRef.cpp View 2 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
reed1
6 years, 11 months ago (2014-01-06 17:08:37 UTC) #1
Message was sent while issue was closed.
Committed patchset #2 manually as r12910 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698