Source/core/html/HTMLFrameElementBase.cpp - Issue 1232223002: Rename LockBackForwardList to ReplaceCurrentItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFrameElementBase.cpp

Issue 1232223002: Rename LockBackForwardList to ReplaceCurrentItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLFrameElementBase.cpp

diff --git a/Source/core/html/HTMLFrameElementBase.cpp b/Source/core/html/HTMLFrameElementBase.cpp

index c37f911833778e8e143314420f6762c0a9e63a7c..a12c3d0a40fd2fde0df2713c1bb3c85fc588db23 100644

--- a/Source/core/html/HTMLFrameElementBase.cpp

+++ b/Source/core/html/HTMLFrameElementBase.cpp

@@ -70,7 +70,7 @@ bool HTMLFrameElementBase::isURLAllowed() const

return true;

}

-void HTMLFrameElementBase::openURL(bool lockBackForwardList)

+void HTMLFrameElementBase::openURL(bool replaceCurrentItem)

{

if (!isURLAllowed())

return;

@@ -90,7 +90,7 @@ void HTMLFrameElementBase::openURL(bool lockBackForwardList)

url = blankURL();

}

- if (!loadOrRedirectSubframe(url, m_frameName, lockBackForwardList))

+ if (!loadOrRedirectSubframe(url, m_frameName, replaceCurrentItem))

return;

if (!contentFrame() || scriptURL.isEmpty() || !contentFrame()->isLocalFrame())

return;

« no previous file with comments | « Source/core/html/HTMLFrameElementBase.h ('k') | Source/core/html/HTMLFrameOwnerElement.h » ('j') | Source/core/loader/FrameLoadRequest.h » ('J')