Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1232213002: Revert "Fix key input." (Closed)

Created:
5 years, 5 months ago by slan
Modified:
5 years, 5 months ago
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, sfunkenhauser-google
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Fix key input." This reverts commit 3a6a03bd2f7f796d03df95152723abfeee0061f2. Note: Also removes now-stale dependency on "aura_test_support". BUG=b/22410943 Committed: https://crrev.com/0ffe2c1fe6c528e3e9ee88e2d394571705a9d35c Cr-Commit-Position: refs/heads/master@{#338406}

Patch Set 1 #

Patch Set 2 : Remove aura_test_support dep. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M chromecast/browser/cast_content_window.h View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M chromecast/browser/cast_content_window.cc View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M chromecast/chromecast.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (7 generated)
slan
+gunsch@ as original reviewer. +esum@ as issue owner. +halliwell@ as owner. Will not submit until ...
5 years, 5 months ago (2015-07-10 22:51:16 UTC) #2
halliwell
On 2015/07/10 22:51:16, slan wrote: > +gunsch@ as original reviewer. > +esum@ as issue owner. ...
5 years, 5 months ago (2015-07-10 23:18:08 UTC) #3
gunsch
lgtm
5 years, 5 months ago (2015-07-10 23:21:17 UTC) #4
gunsch
+cc Scott: we're operating under the assumption that Fiber doesn't need this anymore, due to ...
5 years, 5 months ago (2015-07-10 23:22:12 UTC) #5
slan
On 2015/07/10 23:18:08, halliwell wrote: > On 2015/07/10 22:51:16, slan wrote: > > +gunsch@ as ...
5 years, 5 months ago (2015-07-10 23:22:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232213002/40001
5 years, 5 months ago (2015-07-10 23:24:26 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232213002/40001
5 years, 5 months ago (2015-07-10 23:30:42 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-10 23:39:12 UTC) #13
esum
lgtm
5 years, 5 months ago (2015-07-10 23:55:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232213002/40001
5 years, 5 months ago (2015-07-11 00:05:43 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-11 00:10:38 UTC) #18
commit-bot: I haz the power
5 years, 5 months ago (2015-07-11 00:11:39 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0ffe2c1fe6c528e3e9ee88e2d394571705a9d35c
Cr-Commit-Position: refs/heads/master@{#338406}

Powered by Google App Engine
This is Rietveld 408576698