Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1232203003: Sort unexpected test results. (Closed)

Created:
5 years, 5 months ago by Lei Zhang
Modified:
5 years, 5 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M testing/tools/run_corpus_tests.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M testing/tools/run_javascript_tests.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M testing/tools/run_pixel_tests.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Lei Zhang
5 years, 5 months ago (2015-07-16 17:26:55 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1232203003/diff/1/testing/tools/run_corpus_tests.py File testing/tools/run_corpus_tests.py (right): https://codereview.chromium.org/1232203003/diff/1/testing/tools/run_corpus_tests.py#newcode77 testing/tools/run_corpus_tests.py:77: surprise.sort() nit: would prefer all of these one ...
5 years, 5 months ago (2015-07-16 18:13:20 UTC) #3
Lei Zhang
https://codereview.chromium.org/1232203003/diff/1/testing/tools/run_corpus_tests.py File testing/tools/run_corpus_tests.py (right): https://codereview.chromium.org/1232203003/diff/1/testing/tools/run_corpus_tests.py#newcode77 testing/tools/run_corpus_tests.py:77: surprise.sort() On 2015/07/16 18:13:20, Tom Sepez wrote: > nit: ...
5 years, 5 months ago (2015-07-16 19:06:38 UTC) #4
Lei Zhang
5 years, 5 months ago (2015-07-16 19:07:18 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d3611f9db615be393016a8ab5340ccea7f13832b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698