Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: google_apis/gcm/engine/unregistration_request_unittest.cc

Issue 1232193002: Replace MessageLoop::current() with ThreadTaskRunnerHandle::Get() in GCM (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gcm/engine/unregistration_request_unittest.cc
diff --git a/google_apis/gcm/engine/unregistration_request_unittest.cc b/google_apis/gcm/engine/unregistration_request_unittest.cc
index e850de88c0e2bb847adc935284e02bd3c6004843..0f26c0833e28263cba46fe3a5e203dce20f44675 100644
--- a/google_apis/gcm/engine/unregistration_request_unittest.cc
+++ b/google_apis/gcm/engine/unregistration_request_unittest.cc
@@ -8,6 +8,8 @@
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_tokenizer.h"
+#include "base/test/test_simple_task_runner.h"
+#include "base/thread_task_runner_handle.h"
#include "google_apis/gcm/engine/gcm_unregistration_request_handler.h"
#include "google_apis/gcm/engine/instance_id_delete_token_request_handler.h"
#include "google_apis/gcm/monitoring/fake_gcm_stats_recorder.h"
@@ -83,7 +85,8 @@ class UnregistrationRequestTest : public testing::Test {
bool callback_called_;
UnregistrationRequest::Status status_;
scoped_ptr<UnregistrationRequest> request_;
- base::MessageLoop message_loop_;
+ scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
+ base::ThreadTaskRunnerHandle task_runner_handle_;
net::TestURLFetcherFactory url_fetcher_factory_;
scoped_refptr<net::TestURLRequestContextGetter> url_request_context_getter_;
FakeGCMStatsRecorder recorder_;
@@ -93,8 +96,10 @@ UnregistrationRequestTest::UnregistrationRequestTest()
: max_retry_count_(kMaxRetries),
callback_called_(false),
status_(UnregistrationRequest::UNREGISTRATION_STATUS_COUNT),
+ task_runner_(new base::TestSimpleTaskRunner()),
+ task_runner_handle_(task_runner_),
url_request_context_getter_(new net::TestURLRequestContextGetter(
- message_loop_.task_runner())) {}
+ task_runner_)) {}
UnregistrationRequestTest::~UnregistrationRequestTest() {}

Powered by Google App Engine
This is Rietveld 408576698