google_apis/gcm/engine/connection_factory_impl_unittest.cc - Issue 1232193002: Replace MessageLoop::current() with ThreadTaskRunnerHandle::Get() in GCM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/connection_factory_impl_unittest.cc

Issue 1232193002: Replace MessageLoop::current() with ThreadTaskRunnerHandle::Get() in GCM (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« google_apis/gcm/base/mcs_message_unittest.cc ('K') | « google_apis/gcm/engine/connection_factory_impl.cc ('k') | google_apis/gcm/engine/connection_handler_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: google_apis/gcm/engine/connection_factory_impl_unittest.cc

diff --git a/google_apis/gcm/engine/connection_factory_impl_unittest.cc b/google_apis/gcm/engine/connection_factory_impl_unittest.cc

index 4c0e127bd63e4522f2d26a810e7020c235bed179..31d907d3fac30fd7c5b4a8fd111fa7fb1b680194 100644

--- a/google_apis/gcm/engine/connection_factory_impl_unittest.cc

+++ b/google_apis/gcm/engine/connection_factory_impl_unittest.cc

@@ -272,9 +272,9 @@ class ConnectionFactoryImplTest

};

ConnectionFactoryImplTest::ConnectionFactoryImplTest()

- : factory_(base::Bind(&ConnectionFactoryImplTest::ConnectionsComplete,

+ : factory_(base::Bind(&ConnectionFactoryImplTest::ConnectionsComplete,

base::Unretained(this))),

- run_loop_(new base::RunLoop()) {

+ run_loop_(new base::RunLoop()) {

factory()->SetConnectionListener(this);

factory()->Initialize(

ConnectionFactory::BuildLoginRequestCallback(),

@@ -433,7 +433,7 @@ TEST_F(ConnectionFactoryImplTest, CanarySucceedsRetryDuringLogin) {

EXPECT_FALSE(factory()->IsEndpointReachable());

// Pump the loop, to ensure the pending backoff retry has no effect.

- base::MessageLoop::current()->PostDelayedTask(

+ base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(

FROM_HERE,

base::MessageLoop::QuitClosure(),

base::TimeDelta::FromMilliseconds(1));