Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: components/gcm_driver/gcm_channel_status_request_unittest.cc

Issue 1232193002: Replace MessageLoop::current() with ThreadTaskRunnerHandle::Get() in GCM (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_channel_status_request_unittest.cc
diff --git a/components/gcm_driver/gcm_channel_status_request_unittest.cc b/components/gcm_driver/gcm_channel_status_request_unittest.cc
index 4bb3c69fb8d007693f6a3d37d77b95a85696a26d..3190345d58a1a641403efa8c5929f25ea4de8b7e 100644
--- a/components/gcm_driver/gcm_channel_status_request_unittest.cc
+++ b/components/gcm_driver/gcm_channel_status_request_unittest.cc
@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "base/test/test_simple_task_runner.h"
+#include "base/thread_task_runner_handle.h"
#include "components/gcm_driver/gcm_channel_status_request.h"
#include "net/url_request/test_url_fetcher_factory.h"
#include "net/url_request/url_request_test_util.h"
@@ -33,7 +35,8 @@ class GCMChannelStatusRequestTest : public testing::Test {
int poll_interval_seconds);
scoped_ptr<GCMChannelStatusRequest> request_;
- base::MessageLoop message_loop_;
+ scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
+ base::ThreadTaskRunnerHandle task_runner_handle_;
net::TestURLFetcherFactory url_fetcher_factory_;
scoped_refptr<net::TestURLRequestContextGetter> url_request_context_getter_;
bool request_callback_invoked_;
@@ -43,8 +46,10 @@ class GCMChannelStatusRequestTest : public testing::Test {
};
GCMChannelStatusRequestTest::GCMChannelStatusRequestTest()
- : url_request_context_getter_(
- new net::TestURLRequestContextGetter(message_loop_.task_runner())),
+ : task_runner_(new base::TestSimpleTaskRunner()),
+ task_runner_handle_(task_runner_),
+ url_request_context_getter_(
+ new net::TestURLRequestContextGetter(task_runner_)),
request_callback_invoked_(false),
update_received_(false),
enabled_(true),
« no previous file with comments | « no previous file | google_apis/gcm/base/mcs_message_unittest.cc » ('j') | google_apis/gcm/base/mcs_message_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698