Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1232183002: Add an cross include path for ARM to work around clang bug 22937. (Closed)

Created:
5 years, 5 months ago by jvoung (off chromium)
Modified:
5 years, 5 months ago
Reviewers:
Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add an cross include path for ARM to work around clang bug 22937. Clang appears to be missing an include path to find bits/c++config.h so we were unable to compile the unsandboxed c++ based cross tests and link against the subzero unsandboxed ARM object files. Work around this for now by finding and including the missing path. Turn on a few ARM cross tests that should be working (mem_intrin and test_strengthreduce -- though the strength-reduction isn't done for ARM). The test_bitmanip still fails, because under Om1 we overflow the stack offset and need to materialize that offset with a register first. Update a few other references that still say x8632. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076 R=jpp@chromium.org, stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=112b6e89a1e6360a50cd1c89b546fdec71d7329e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -8 lines) Patch
M Makefile.standalone View 1 chunk +3 lines, -1 line 0 comments Download
M pydir/crosstest.py View 2 chunks +5 lines, -3 lines 0 comments Download
M pydir/targets.py View 1 chunk +22 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jvoung (off chromium)
5 years, 5 months ago (2015-07-10 21:41:23 UTC) #2
John
lgtm
5 years, 5 months ago (2015-07-10 23:38:55 UTC) #3
Jim Stichnoth
lgtm
5 years, 5 months ago (2015-07-13 17:06:59 UTC) #4
jvoung (off chromium)
5 years, 5 months ago (2015-07-13 18:36:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
112b6e89a1e6360a50cd1c89b546fdec71d7329e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698