Remove GL-specific code from GMs and tests

Remove GL-specific code from GMs and tests

TBR=bsalomon@google.com

Committed: https://skia.googlesource.com/skia/+/672bb7fc6640e3fc68107354ed4ae45a2a1e2d29

[jvanverth1, 2015-07-10 18:05:49]

jvanverth@google.com changed reviewers:
+ egdaniel@google.com, robertphillips@google.com

[robertphillips, 2015-07-10 18:45:18]

https://codereview.chromium.org/1232173002/diff/40001/gm/imagefromyuvtextures...
File gm/imagefromyuvtextures.cpp (right):

https://codereview.chromium.org/1232173002/diff/40001/gm/imagefromyuvtextures...
gm/imagefromyuvtextures.cpp:96: 
can this be static ?

https://codereview.chromium.org/1232173002/diff/40001/gm/imagefromyuvtextures...
gm/imagefromyuvtextures.cpp:112: 
this too ?

https://codereview.chromium.org/1232173002/diff/40001/src/gpu/GrGpu.h
File src/gpu/GrGpu.h (right):

https://codereview.chromium.org/1232173002/diff/40001/src/gpu/GrGpu.h#newcode366
src/gpu/GrGpu.h:366: virtual GrBackendObject createBackendTexture(void* pixels,
int w, int h,
tab this over ?

https://codereview.chromium.org/1232173002/diff/40001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1232173002/diff/40001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:3070: GrBackendObject GrGLGpu::createBackendTexture(void*
pixels, int w, int h,
tab over ?

https://codereview.chromium.org/1232173002/diff/40001/tests/ResourceCacheTest...
File tests/ResourceCacheTest.cpp (right):

https://codereview.chromium.org/1232173002/diff/40001/tests/ResourceCacheTest...
tests/ResourceCacheTest.cpp:220: 
delete borrowed ?

[jvanverth1, 2015-07-10 19:59:44]

Fixed GLBench and addressed Rob's comments. PTAL.

https://codereview.chromium.org/1232173002/diff/40001/gm/imagefromyuvtextures...
File gm/imagefromyuvtextures.cpp (right):

https://codereview.chromium.org/1232173002/diff/40001/gm/imagefromyuvtextures...
gm/imagefromyuvtextures.cpp:96: 
On 2015/07/10 18:45:18, robertphillips wrote:
> can this be static ?

It uses fUVBmps[].

https://codereview.chromium.org/1232173002/diff/40001/src/gpu/GrGpu.h
File src/gpu/GrGpu.h (right):

https://codereview.chromium.org/1232173002/diff/40001/src/gpu/GrGpu.h#newcode366
src/gpu/GrGpu.h:366: virtual GrBackendObject createBackendTexture(void* pixels,
int w, int h,
On 2015/07/10 18:45:18, robertphillips wrote:
> tab this over ?

Done.

https://codereview.chromium.org/1232173002/diff/40001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1232173002/diff/40001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:3070: GrBackendObject GrGLGpu::createBackendTexture(void*
pixels, int w, int h,
On 2015/07/10 18:45:18, robertphillips wrote:
> tab over ?

Done.

https://codereview.chromium.org/1232173002/diff/40001/tests/ResourceCacheTest...
File tests/ResourceCacheTest.cpp (right):

https://codereview.chromium.org/1232173002/diff/40001/tests/ResourceCacheTest...
tests/ResourceCacheTest.cpp:220: 
On 2015/07/10 18:45:18, robertphillips wrote:
> delete borrowed ?

Done.

[egdaniel, 2015-07-10 20:10:45]

lgtm with minor comment

https://codereview.chromium.org/1232173002/diff/60001/bench/GLBench.cpp
File bench/GLBench.cpp (right):

https://codereview.chromium.org/1232173002/diff/60001/bench/GLBench.cpp#newco...
bench/GLBench.cpp:28: SkDebugf("Couldn't get an interface\n");
Should we remove this print so it doesn't spam?

[robertphillips, 2015-07-10 20:23:41]

lgtm + typo

https://codereview.chromium.org/1232173002/diff/60001/gm/imagefromyuvtextures...
File gm/imagefromyuvtextures.cpp (right):

https://codereview.chromium.org/1232173002/diff/60001/gm/imagefromyuvtextures...
gm/imagefromyuvtextures.cpp:97: void createYUVTextures(GrContext* context,
GrBackendObject yuvIDs[3]) {
hav -> have ?

[jvanverth1, 2015-07-13 13:48:43]

On 2015/07/10 20:10:45, egdaniel wrote:
> lgtm with minor comment
> 
> https://codereview.chromium.org/1232173002/diff/60001/bench/GLBench.cpp
> File bench/GLBench.cpp (right):
> 
>
https://codereview.chromium.org/1232173002/diff/60001/bench/GLBench.cpp#newco...
> bench/GLBench.cpp:28: SkDebugf("Couldn't get an interface\n");
> Should we remove this print so it doesn't spam?

I'm inclined to leave it as it might help someone track down an issue. We don't
run benches in debug on the trybots.

[jvanverth1, 2015-07-13 13:58:58]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2015-07-13 13:58:58]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com,
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1232173002/#ps80001
(title: "Remove outdated comments")

[commit-bot: I haz the power, 2015-07-13 13:59:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1232173002/80001

[commit-bot: I haz the power, 2015-07-13 14:00:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-13 14:00:43]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[jvanverth1, 2015-07-13 14:06:17]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2015-07-13 14:06:18]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com,
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1232173002/#ps100001
(title: "Get rid of warning")

[commit-bot: I haz the power, 2015-07-13 14:06:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1232173002/100001

[commit-bot: I haz the power, 2015-07-13 14:20:02]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/672bb7fc6640e3fc68107354ed4ae45a2a1e2d29

[bsalomon, 2015-07-14 14:01:21]

On 2015/07/13 14:20:02, commit-bot: I haz the power wrote:
> Committed patchset #6 (id:100001) as
> https://skia.googlesource.com/skia/+/672bb7fc6640e3fc68107354ed4ae45a2a1e2d29

I agree with these changes. These are testing using externally created textures
in Ganesh and now Ganesh is creating the textures and we're pretending that
they're external. We could wind up with subtle bugs because the same texture ID
is owned by two GrTextures. Also, we will need to add support for testing cases
of texture types that Ganesh does not create (GL_TEXTURE_EXTERNAL_OES). I think
these tests should have alternate implementations for generating the external
textures on other backends. Perhaps we should have a test only utility rather
than repeating a lot of GL in different places.

[bsalomon, 2015-07-14 14:01:42]

On 2015/07/14 14:01:21, bsalomon wrote:
> On 2015/07/13 14:20:02, commit-bot: I haz the power wrote:
> > Committed patchset #6 (id:100001) as
> >
https://skia.googlesource.com/skia/+/672bb7fc6640e3fc68107354ed4ae45a2a1e2d29
> 
> I agree with these changes. These are testing using externally created
textures
> in Ganesh and now Ganesh is creating the textures and we're pretending that
> they're external. We could wind up with subtle bugs because the same texture
ID
> is owned by two GrTextures. Also, we will need to add support for testing
cases
> of texture types that Ganesh does not create (GL_TEXTURE_EXTERNAL_OES). I
think
> these tests should have alternate implementations for generating the external
> textures on other backends. Perhaps we should have a test only utility rather
> than repeating a lot of GL in different places.

I meant "I don't agree with these changes".

[bsalomon, 2015-07-14 14:06:34]

I misread the change.... sorry! It seems ok! I'd just like it to be clear that
the new functions on GPU are for testing only.