Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Unified Diff: chrome/browser/android/tab_android.cc

Issue 1232123009: customtabs: Pre-create a renderer in mayLaunchUrl(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/tab_android.cc
diff --git a/chrome/browser/android/tab_android.cc b/chrome/browser/android/tab_android.cc
index 5bf79afa4b055de8ecf3de849012d2f51f2f194a..f9682bd1a8f98c2859e584361d11a01d54ff0d79 100644
--- a/chrome/browser/android/tab_android.cc
+++ b/chrome/browser/android/tab_android.cc
@@ -527,17 +527,19 @@ base::android::ScopedJavaLocalRef<jobject> TabAndroid::GetProfileAndroid(
return profile_android->GetJavaObject();
}
-TabAndroid::TabLoadStatus TabAndroid::LoadUrl(JNIEnv* env,
- jobject obj,
- jstring url,
- jstring j_extra_headers,
- jbyteArray j_post_data,
- jint page_transition,
- jstring j_referrer_url,
- jint referrer_policy,
- jboolean is_renderer_initiated,
- jlong intent_received_timestamp,
- jboolean has_user_gesture) {
+TabAndroid::TabLoadStatus TabAndroid::LoadUrl(
+ JNIEnv* env,
+ jobject obj,
+ jstring url,
+ jstring j_extra_headers,
+ jbyteArray j_post_data,
+ jint page_transition,
+ jstring j_referrer_url,
+ jint referrer_policy,
+ jboolean is_renderer_initiated,
+ jboolean should_replace_current_entry,
+ jlong intent_received_timestamp,
+ jboolean has_user_gesture) {
if (!web_contents())
return PAGE_LOAD_FAILED;
@@ -619,6 +621,7 @@ TabAndroid::TabLoadStatus TabAndroid::LoadUrl(JNIEnv* env,
return DEFAULT_PAGE_LOAD;
}
load_params.is_renderer_initiated = is_renderer_initiated;
+ load_params.should_replace_current_entry = should_replace_current_entry;
load_params.intent_received_timestamp = intent_received_timestamp;
load_params.has_user_gesture = has_user_gesture;
web_contents()->GetController().LoadURLWithParams(load_params);
« no previous file with comments | « chrome/browser/android/tab_android.h ('k') | chrome/browser/history/android/android_provider_backend_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698