Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4626)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 1232123009: customtabs: Pre-create a renderer in mayLaunchUrl(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index e6fc0a66a9c6a19e034b5801e95d1b6186554bbc..b47019ca6d05e78bd242d7cb97f37db6b5822c03 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -925,19 +925,15 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
// We load the URL from the tab rather than directly from the ContentView so the tab has
// a chance of using a prerenderer page is any.
- int loadType = nativeLoadUrl(
- mNativeTabAndroid,
- params.getUrl(),
- params.getVerbatimHeaders(),
- params.getPostData(),
- params.getTransitionType(),
+ int loadType = nativeLoadUrl(mNativeTabAndroid, params.getUrl(),
+ params.getVerbatimHeaders(), params.getPostData(), params.getTransitionType(),
params.getReferrer() != null ? params.getReferrer().getUrl() : null,
// Policy will be ignored for null referrer url, 0 is just a placeholder.
// TODO(ppi): Should we pass Referrer jobject and add JNI methods to read it
// from the native?
params.getReferrer() != null ? params.getReferrer().getPolicy() : 0,
- params.getIsRendererInitiated(), params.getIntentReceivedTimestamp(),
- params.getHasUserGesture());
+ params.getIsRendererInitiated(), params.getShouldReplaceCurrentEntry(),
+ params.getIntentReceivedTimestamp(), params.getHasUserGesture());
for (TabObserver observer : mObservers) {
observer.onLoadUrl(this, params, loadType);
@@ -2813,7 +2809,8 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
private native Profile nativeGetProfileAndroid(long nativeTabAndroid);
private native int nativeLoadUrl(long nativeTabAndroid, String url, String extraHeaders,
byte[] postData, int transition, String referrerUrl, int referrerPolicy,
- boolean isRendererInitiated, long intentReceivedTimestamp, boolean hasUserGesture);
+ boolean isRendererInitiated, boolean shoulReplaceCurrentEntry,
+ long intentReceivedTimestamp, boolean hasUserGesture);
private native void nativeSetActiveNavigationEntryTitleForUrl(long nativeTabAndroid, String url,
String title);
private native boolean nativePrint(long nativeTabAndroid);

Powered by Google App Engine
This is Rietveld 408576698