Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: src/hydrogen-instructions.h

Issue 12321165: Fixed HCheckSmiOrInt <-> HBoundsCheck interaction wrt. representations (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2829 matching lines...) Expand 10 before | Expand all | Expand 10 after
2840 virtual Representation RequiredInputRepresentation(int index) { 2840 virtual Representation RequiredInputRepresentation(int index) {
2841 return representation(); 2841 return representation();
2842 } 2842 }
2843 virtual void InferRepresentation(HInferRepresentation* h_infer); 2843 virtual void InferRepresentation(HInferRepresentation* h_infer);
2844 2844
2845 virtual Representation observed_input_representation(int index) { 2845 virtual Representation observed_input_representation(int index) {
2846 return Representation::Integer32(); 2846 return Representation::Integer32();
2847 } 2847 }
2848 2848
2849 virtual HValue* Canonicalize() { 2849 virtual HValue* Canonicalize() {
2850 if (representation().IsTagged() && !type().IsSmi()) { 2850 if (representation().IsTagged() && !value()->type().IsSmi()) {
2851 return this; 2851 return this;
2852 } else { 2852 } else {
2853 return value(); 2853 return value();
2854 } 2854 }
2855 } 2855 }
2856 2856
2857 DECLARE_CONCRETE_INSTRUCTION(CheckSmiOrInt32) 2857 DECLARE_CONCRETE_INSTRUCTION(CheckSmiOrInt32)
2858 2858
2859 protected: 2859 protected:
2860 virtual bool DataEquals(HValue* other) { return true; } 2860 virtual bool DataEquals(HValue* other) { return true; }
(...skipping 3281 matching lines...) Expand 10 before | Expand all | Expand 10 after
6142 virtual bool IsDeletable() const { return true; } 6142 virtual bool IsDeletable() const { return true; }
6143 }; 6143 };
6144 6144
6145 6145
6146 #undef DECLARE_INSTRUCTION 6146 #undef DECLARE_INSTRUCTION
6147 #undef DECLARE_CONCRETE_INSTRUCTION 6147 #undef DECLARE_CONCRETE_INSTRUCTION
6148 6148
6149 } } // namespace v8::internal 6149 } } // namespace v8::internal
6150 6150
6151 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 6151 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698