Prevent URLRequestRedirectJob from doing async execution

net/url_request/url_request_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shlobj.h>
 #endif
@@ skipping 9192 matching lines @@
   scoped_ptr<URLRequest> req(context.CreateRequest(
       GURL("http://test_intercept/foo"), DEFAULT_PRIORITY, &d));
 
   EXPECT_FALSE(req->response_info().network_accessed);
 
   req->Start();
   base::RunLoop().Run();
   EXPECT_TRUE(req->response_info().network_accessed);
 }
 
+TEST_F(URLRequestTest, URLRequestRedirectJobDetachRequestNoCrash) {
+  // URLRequest should be canceled correctly and with detached request
+  // URLRequestRedirectJob should not crash in StartAsync.
+  // See http://crbug.com/508900

[mmenke, 2015/07/22 19:05:04]

nit:  Method descriptions should go before the method.

+
+  TestDelegate d;
+  scoped_ptr<URLRequest> req(default_context_.CreateRequest(
+      GURL("http://not-a-real-domain/"), DEFAULT_PRIORITY, &d));
+
+  URLRequestRedirectJob* job = new URLRequestRedirectJob(
+      req.get(), &default_network_delegate_,
+      GURL("http://this-should-never-be-navigated-to/"),
+      URLRequestRedirectJob::REDIRECT_307_TEMPORARY_REDIRECT, "Jumbo shrimp");
+  AddTestInterceptor()->set_main_intercept_job(job);
+
+  req->Start();
+  req->Cancel();
+  job->DetachRequest();
+  base::RunLoop().RunUntilIdle();
+  EXPECT_EQ(URLRequestStatus::CANCELED, req->status().status());
+  EXPECT_EQ(0, d.received_redirect_count());
+}
+
 }  // namespace net