Issue 12321129: Expand part declarations in the builtin library python scripts to avoid having to repeat part decla…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12321129: Expand part declarations in the builtin library python scripts to avoid having to repeat part decla… (Closed)

Created:
7 years, 10 months ago by Mads Ager (google)

Modified:
7 years, 10 months ago

Reviewers:
siva, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Expand part declarations in the builtin library python scripts to avoid having to repeat part declarations in files. Treat dart:io the same as the other builtin libraries. R=iposva@google.com,asiva@google.com BUG=

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -147 lines)			Patch
M	runtime/bin/bin.gypi	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	runtime/bin/io.dart	View	1 chunk	+1 line, -14 lines	0 comments	Download
M	runtime/bin/io_sources.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/tools/concat_library.py	View	3 chunks	+21 lines, -8 lines	0 comments	Download
M	sdk/lib/_collection_dev/collection_dev_sources.gypi	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	sdk/lib/async/async_sources.gypi	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	sdk/lib/collection/collection_sources.gypi	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	sdk/lib/core/corelib_sources.gypi	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	sdk/lib/crypto/crypto_sources.gypi	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	sdk/lib/io/iolib_sources.gypi	View	1 chunk	+1 line, -30 lines	0 comments	Download
M	sdk/lib/isolate/isolate_sources.gypi	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sdk/lib/json/json_sources.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sdk/lib/math/math_sources.gypi	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sdk/lib/mirrors/mirrors_sources.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sdk/lib/scalarlist/scalarlist_sources.gypi	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sdk/lib/uri/uri_sources.gypi	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sdk/lib/utf/utf_sources.gypi	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Please explain how this scenario works: a.) Change a .cc file. b.) Build. c.) Change ...

7 years, 10 months ago (2013-02-26 16:17:34 UTC) #2

Mads Ager (google)

7 years, 10 months ago (2013-02-26 16:20:59 UTC) #3

You are absolutely right. This doesn't work. Annoying. I really wish we didn't
have to have the repeated sources in the gypi file. :(

Expand Messages | Collapse Messages