webkit/fileapi/file_system_dir_url_request_job_unittest.cc - Issue 12321106: Update TestURLRequest constructor interface in unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/fileapi/file_system_dir_url_request_job_unittest.cc

Issue 12321106: Update TestURLRequest constructor interface in unit tests. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Make use of empty delegate more explicit, and fix one broken test. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/fileapi/file_system_dir_url_request_job_unittest.cc

diff --git a/webkit/fileapi/file_system_dir_url_request_job_unittest.cc b/webkit/fileapi/file_system_dir_url_request_job_unittest.cc

index 19aa253653874b14df2f8ad1be4af8606a67acb9..cacb8ca1a4ce3d431448c3592f943a68cfaa5676 100644

--- a/webkit/fileapi/file_system_dir_url_request_job_unittest.cc

+++ b/webkit/fileapi/file_system_dir_url_request_job_unittest.cc

@@ -88,9 +88,7 @@ class FileSystemDirURLRequestJobTest : public testing::Test {

delegate_->set_quit_on_redirect(true);

request_.reset(empty_context_.CreateRequest(url, delegate_.get()));

job_ = new FileSystemDirURLRequestJob(

- request_.get(),

- empty_context_.network_delegate(),

- file_system_context_.get());

+ request_.get(), NULL, file_system_context_.get());

request_->Start();

ASSERT_TRUE(request_->is_pending()); // verify that we're starting async