sdk/lib/utf/utf_sources.gypi - Issue 12321082: - Properly load the core libraries as libraries and not as scripts.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sdk/lib/utf/utf_sources.gypi

Issue 12321082: - Properly load the core libraries as libraries and not as scripts. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 # for details. All rights reserved. Use of this source code is governed by a	2 # for details. All rights reserved. Use of this source code is governed by a

3 # BSD-style license that can be found in the LICENSE file.	3 # BSD-style license that can be found in the LICENSE file.

4	4

5 # This file contains all sources for the dart:utf library.	5 # This file contains all sources for the dart:utf library.

6 #	6 #

7 # TODO(ager): When the VM can use the #source directive for libraries.	7 # TODO(ager): When the VM can use the #source directive for libraries.

8 # At that point utf.dart should be the only utf library file.	8 # At that point utf.dart should be the only utf library file.
	siva 2013/02/25 23:12:25 This TODO can go. This TODO can go. Ivan Posva 2013/02/25 23:23:58 Done. Show quoted text On 2013/02/25 23:12:25, siva wrote: > This TODO can go. Done. Mads Ager (google) 2013/02/26 07:40:51 This is great, thanks! We are only half-way to the Show quoted text On 2013/02/25 23:23:58, Ivan Posva wrote: > On 2013/02/25 23:12:25, siva wrote: > > This TODO can go. > > Done. This is great, thanks! We are only half-way to the goal of the TODO. We still need to list all the parts in this file and cannot just use the utf.dart library file. How hard would it be to avoid that? The information is already in the utf.dart file and it would be cool if that was enough. That would make it easier to hack on these core libraries without having to mess with gyp files. I guess the understanding of the part declarations would have to be in the python script which is of course an added complication in that script.
9 {	9 {

10 'sources': [	10 'sources': [

	11 'utf.dart',

	12 # The above file needs to be first as it lists the parts below.

11 'utf_core.dart',	13 'utf_core.dart',

12 'utf_stream.dart',	14 'utf_stream.dart',

13 'utf8.dart',	15 'utf8.dart',

14 'utf16.dart',	16 'utf16.dart',

15 'utf32.dart',	17 'utf32.dart',

16 ],	18 ],

17 }	19 }

OLD	NEW

« sdk/lib/crypto/crypto_sources.gypi ('K') | « sdk/lib/uri/uri_sources.gypi ('k') | no next file » | no next file with comments »