chrome/installer/test/resource_updater.cc - Issue 12321062: base: Move MemoryMappedFile out of file_util.h and into its own header file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/test/resource_updater.cc

Issue 12321062: base: Move MemoryMappedFile out of file_util.h and into its own header file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix chrome_frame Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc ('k') | chrome/installer/util/move_tree_work_item_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/test/resource_updater.cc

diff --git a/chrome/installer/test/resource_updater.cc b/chrome/installer/test/resource_updater.cc

index 2deb3014ed448a471eed1de233a5c7465730338d..037c169a12984a1714e92021b17d0cff529fdfe1 100644

--- a/chrome/installer/test/resource_updater.cc

+++ b/chrome/installer/test/resource_updater.cc

@@ -8,6 +8,7 @@

#include "base/file_path.h"

#include "base/file_util.h"

brettw 2013/02/22 21:28:15 I wonder if you checked whether some of these file

tfarina 2013/02/22 22:58:54 Done. I ran 'git grep file_util" on all files in t

+#include "base/files/memory_mapped_file.h"

#include "base/logging.h"

namespace upgrade_test {

@@ -39,7 +40,7 @@ bool ResourceUpdater::Update(const std::wstring& name,

WORD language_id,

const base::FilePath& input_file) {

DCHECK(handle_ != NULL);

- file_util::MemoryMappedFile input;

+ base::MemoryMappedFile input;

if (input.Initialize(input_file)) {

if (UpdateResource(handle_, type.c_str(), name.c_str(), language_id,