chrome/installer/util/chrome_browser_sxs_operations.h - Issue 12321061: Pulling user experiment code from BrowserDistribution to a new class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/chrome_browser_sxs_operations.h

Issue 12321061: Pulling user experiment code from BrowserDistribution to a new class. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: *Only* making ProductOperation to use string16 instead of std::wstring; wrapping changes. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/setup/setup_main.cc ('K') | « chrome/installer/util/chrome_browser_operations.cc ('k') | chrome/installer/util/chrome_browser_sxs_operations.cc » ('j') | chrome/installer/util/user_experiment.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/chrome_browser_sxs_operations.h

diff --git a/chrome/installer/util/chrome_browser_sxs_operations.h b/chrome/installer/util/chrome_browser_sxs_operations.h

index 37ffba0b5bb769fb50f7c9273a4c62ba148010c3..f4570123145d9dd2d2deecd862bc1987d01aa71f 100644

--- a/chrome/installer/util/chrome_browser_sxs_operations.h

+++ b/chrome/installer/util/chrome_browser_sxs_operations.h

@@ -16,13 +16,11 @@ class ChromeBrowserSxSOperations : public ChromeBrowserOperations {

public:

ChromeBrowserSxSOperations() {}

- virtual void AppendProductFlags(

- const std::set<std::wstring>& options,

- CommandLine* cmd_line) const OVERRIDE;

+ virtual void AppendProductFlags(const std::set<string16>& options,

+ CommandLine* cmd_line) const OVERRIDE;

- virtual void AppendRenameFlags(

- const std::set<std::wstring>& options,

- CommandLine* cmd_line) const OVERRIDE;

+ virtual void AppendRenameFlags(const std::set<string16>& options,

+ CommandLine* cmd_line) const OVERRIDE;

private:

DISALLOW_COPY_AND_ASSIGN(ChromeBrowserSxSOperations);