chrome/installer/util/google_chrome_sxs_distribution.h - Issue 12321061: Pulling user experiment code from BrowserDistribution to a new class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/google_chrome_sxs_distribution.h

Issue 12321061: Pulling user experiment code from BrowserDistribution to a new class. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Adding GetUserDataPaths() to BrowserDistribution; replacing Product with other params in LaunchUser… Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/util/chrome_app_host_operations.cc ('K') | « chrome/installer/util/google_chrome_distribution_dummy.cc ('k') | chrome/installer/util/google_chrome_sxs_distribution.cc » ('j') | chrome/installer/util/user_experiment.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/google_chrome_sxs_distribution.h

diff --git a/chrome/installer/util/google_chrome_sxs_distribution.h b/chrome/installer/util/google_chrome_sxs_distribution.h

index 9f5e14e5a89f492e612d53f435a8958e4c6b6a48..1d52252ca63c0b05fed032cbd8fc0b35df508e82 100644

--- a/chrome/installer/util/google_chrome_sxs_distribution.h

+++ b/chrome/installer/util/google_chrome_sxs_distribution.h

@@ -31,6 +31,7 @@ class GoogleChromeSxSDistribution : public GoogleChromeDistribution {

string16* handler_class_uuid) OVERRIDE;

virtual bool AppHostIsSupported() OVERRIDE;

virtual bool ShouldSetExperimentLabels() OVERRIDE;

+ virtual bool HasUserExperiments() const OVERRIDE;

grt (UTC plus 2) 2013/03/12 14:32:18 this override is unnecessary. have you added it ju

huangs 2013/03/12 18:03:07 Yes, to assert that Canary also runs the experimen

// returns the channel name for GoogleChromeSxSDistribution

static string16 ChannelName();

private: