chrome/test/chromedriver/window_commands.cc - Issue 12321057: [chromedriver] Implement reconnection to DevTools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/window_commands.cc

Issue 12321057: [chromedriver] Implement reconnection to DevTools. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix nits. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/window_commands.cc

diff --git a/chrome/test/chromedriver/window_commands.cc b/chrome/test/chromedriver/window_commands.cc

index f92815a387987b8b1231b8ccb677e1306d61bf24..78a25058e50043123e8ec8f2d51932d8989a7c35 100644

--- a/chrome/test/chromedriver/window_commands.cc

+++ b/chrome/test/chromedriver/window_commands.cc

@@ -52,6 +52,10 @@ Status ExecuteWindowCommand(

if (status.IsError())

return status;

+ status = web_view->EnsureAlive();

+ if (status.IsError())

+ return status;

Status nav_status = web_view->WaitForPendingNavigations(session->frame);

if (nav_status.IsError())

return nav_status;