Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/test/chromedriver/net/sync_websocket_impl.h

Issue 12321057: [chromedriver] Implement reconnection to DevTools. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix nits. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/net/sync_websocket_impl.h
diff --git a/chrome/test/chromedriver/net/sync_websocket_impl.h b/chrome/test/chromedriver/net/sync_websocket_impl.h
index 28aaa98a76f30efc75d3dfdc8b4f8a2a7ce356d5..ccb4e88cdd0f33df340acf664259b0128e4d5761 100644
--- a/chrome/test/chromedriver/net/sync_websocket_impl.h
+++ b/chrome/test/chromedriver/net/sync_websocket_impl.h
@@ -35,6 +35,7 @@ class SyncWebSocketImpl : public SyncWebSocket {
virtual ~SyncWebSocketImpl();
// Overridden from SyncWebSocket:
+ virtual bool IsConnected() OVERRIDE;
virtual bool Connect(const GURL& url) OVERRIDE;
virtual bool Send(const std::string& message) OVERRIDE;
virtual bool ReceiveNextMessage(std::string* message) OVERRIDE;
@@ -47,6 +48,8 @@ class SyncWebSocketImpl : public SyncWebSocket {
public:
explicit Core(net::URLRequestContextGetter* context_getter);
+ bool IsConnected();
+
bool Connect(const GURL& url);
bool Send(const std::string& message);
@@ -87,7 +90,7 @@ class SyncWebSocketImpl : public SyncWebSocket {
base::Lock lock_;
// Protected by |lock_|.
- bool closed_;
+ bool open_;
kkania 2013/03/04 23:33:57 how about change this to is_connected_ to be consi
chrisgao (Use stgao instead) 2013/03/05 06:58:17 Done.
// Protected by |lock_|.
std::list<std::string> received_queue_;

Powered by Google App Engine
This is Rietveld 408576698