Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6900)

Unified Diff: chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc

Issue 12321057: [chromedriver] Implement reconnection to DevTools. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix some nits and add one unit test. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc
diff --git a/chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc b/chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc
index 6df195ac254111c108e8e6bb23bb7496ac85805e..306433e58d56de2af222c4a214916f5bd9c9e542 100644
--- a/chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc
+++ b/chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc
@@ -109,3 +109,14 @@ TEST_F(SyncWebSocketImplTest, CloseOnSend) {
server_.Stop();
ASSERT_FALSE(sock.Send("1"));
}
+
+TEST_F(SyncWebSocketImplTest, Reconnect) {
+ SyncWebSocketImpl sock(context_getter_);
+ ASSERT_TRUE(sock.Connect(server_.web_socket_url()));
+ ASSERT_TRUE(sock.Send("1"));
+ server_.Stop();
+ ASSERT_FALSE(sock.Send("1"));
+ server_.Start();
+ ASSERT_TRUE(sock.Connect(server_.web_socket_url()));
kkania 2013/02/22 01:35:24 how about check in this test that the message queu
chrisgao (Use stgao instead) 2013/02/27 19:29:44 Done.
+ ASSERT_TRUE(sock.Send("1"));
+}

Powered by Google App Engine
This is Rietveld 408576698