Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 1232103006: Add Cards and Fitness demos, remove sector. (Closed)

Created:
5 years, 5 months ago by eseidel
Modified:
5 years, 5 months ago
Reviewers:
abarth, abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add Cards and Fitness demos, remove sector. The launch cards still need to be made nicer. R=abarth@chromium.org, abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/13603612692f42c0589cfdaf01bb0822baf33256

Patch Set 1 #

Patch Set 2 : Add TaskDescriptions to the new demos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -21 lines) Patch
M sky/sdk/example/demo_launcher/lib/main.dart View 1 2 chunks +21 lines, -15 lines 0 comments Download
M sky/sdk/example/fitness/lib/main.dart View 1 3 chunks +6 lines, -2 lines 0 comments Download
M sky/sdk/example/widgets/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download
M sky/sdk/example/widgets/card_collection.dart View 1 2 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-15 23:23:05 UTC) #2
eseidel
5 years, 5 months ago (2015-07-15 23:31:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
13603612692f42c0589cfdaf01bb0822baf33256 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698