Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: src/gpu/gl/GrGLInterface.cpp

Issue 1232103002: Enable stencil clipping in mixed sampled render targets (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/gpu/gl/GrGLInterface.cpp
diff --git a/src/gpu/gl/GrGLInterface.cpp b/src/gpu/gl/GrGLInterface.cpp
index ec51797c7e81cf246b0c39e5df4878414d4c8e87..91c973b7cb36c3e57cb32552d4e98fd9e37cf3be 100644
--- a/src/gpu/gl/GrGLInterface.cpp
+++ b/src/gpu/gl/GrGLInterface.cpp
@@ -701,6 +701,18 @@ bool GrGLInterface::validate() const {
}
}
+ if (glVer >= GR_GL_VER(4,3)) {
Chris Dalton 2015/09/22 08:35:24 I think we also need to check the GL standard and
+ if (NULL == fFunctions.fFramebufferParameteri) {
+ RETURN_FALSE_INTERFACE
+ }
+ if (NULL == fFunctions.fNamedFramebufferSampleLocationsfv) {
Chris Dalton 2015/09/22 08:35:24 We should validate for this method when GL_NV_samp
+ RETURN_FALSE_INTERFACE
+ }
+ if (NULL == fFunctions.fGetMultisamplefv) {
Chris Dalton 2015/09/22 08:35:24 We can validate for this method on GL 3.2 and GLES
+ RETURN_FALSE_INTERFACE
+ }
+ }
+
if ((kGL_GrGLStandard == fStandard && glVer >= GR_GL_VER(4,3)) ||
fExtensions.has("GL_KHR_debug")) {
if (nullptr == fFunctions.fDebugMessageControl ||

Powered by Google App Engine
This is Rietveld 408576698