Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 12321002: Merge 182750 (Closed)

Created:
7 years, 10 months ago by Roger Tawa OOO till Jul 10th
Modified:
7 years, 10 months ago
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

Merge 182750 > Initially the gaia sign in page did not allow the user to turn off the "let me choose want to sync" option when signing in from the settings page. To fix a bug in the page, this is now allowed. The chrome code must now deal with this situation correctly. > > BUG=175819 > > > Review URL: https://chromiumcodereview.appspot.com/12256015 TBR=rogerta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -26 lines) Patch
M chrome/browser/ui/sync/one_click_signin_helper.cc View 8 chunks +26 lines, -24 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Roger Tawa OOO till Jul 10th
7 years, 10 months ago (2013-02-20 02:57:19 UTC) #1
Roger Tawa OOO till Jul 10th
7 years, 10 months ago (2013-02-20 02:58:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r183388.

Powered by Google App Engine
This is Rietveld 408576698