Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: src/objects.cc

Issue 1232083003: Fix bug introduced by 4.4.83.18 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@4.4
Patch Set: Bump version Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « include/v8-version.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <iomanip> 5 #include <iomanip>
6 #include <sstream> 6 #include <sstream>
7 7
8 #include "src/v8.h" 8 #include "src/v8.h"
9 9
10 #include "src/accessors.h" 10 #include "src/accessors.h"
(...skipping 3274 matching lines...) Expand 10 before | Expand all | Expand 10 after
3285 break; 3285 break;
3286 3286
3287 case LookupIterator::INTEGER_INDEXED_EXOTIC: 3287 case LookupIterator::INTEGER_INDEXED_EXOTIC:
3288 return RedefineNonconfigurableProperty(it->isolate(), it->name(), value, 3288 return RedefineNonconfigurableProperty(it->isolate(), it->name(), value,
3289 language_mode); 3289 language_mode);
3290 3290
3291 case LookupIterator::DATA: { 3291 case LookupIterator::DATA: {
3292 PropertyDetails details = own_lookup.property_details(); 3292 PropertyDetails details = own_lookup.property_details();
3293 if (details.IsConfigurable() || !details.IsReadOnly()) { 3293 if (details.IsConfigurable() || !details.IsReadOnly()) {
3294 return JSObject::SetOwnPropertyIgnoreAttributes( 3294 return JSObject::SetOwnPropertyIgnoreAttributes(
3295 Handle<JSObject>(it->GetReceiver()), it->name(), value, 3295 Handle<JSObject>::cast(it->GetReceiver()), it->name(), value,
3296 details.attributes()); 3296 details.attributes());
3297 } 3297 }
3298 return WriteToReadOnlyProperty(&own_lookup, value, language_mode); 3298 return WriteToReadOnlyProperty(&own_lookup, value, language_mode);
3299 } 3299 }
3300 3300
3301 case LookupIterator::ACCESSOR: { 3301 case LookupIterator::ACCESSOR: {
3302 PropertyDetails details = own_lookup.property_details(); 3302 PropertyDetails details = own_lookup.property_details();
3303 if (details.IsConfigurable()) { 3303 if (details.IsConfigurable()) {
3304 return JSObject::SetOwnPropertyIgnoreAttributes( 3304 return JSObject::SetOwnPropertyIgnoreAttributes(
3305 Handle<JSObject>(it->GetReceiver()), it->name(), value, 3305 Handle<JSObject>::cast(it->GetReceiver()), it->name(), value,
3306 details.attributes()); 3306 details.attributes());
3307 } 3307 }
3308 3308
3309 return RedefineNonconfigurableProperty(it->isolate(), it->name(), value, 3309 return RedefineNonconfigurableProperty(it->isolate(), it->name(), value,
3310 language_mode); 3310 language_mode);
3311 } 3311 }
3312 3312
3313 case LookupIterator::INTERCEPTOR: 3313 case LookupIterator::INTERCEPTOR:
3314 case LookupIterator::JSPROXY: { 3314 case LookupIterator::JSPROXY: {
3315 bool found = false; 3315 bool found = false;
(...skipping 13942 matching lines...) Expand 10 before | Expand all | Expand 10 after
17258 void PropertyCell::SetValueWithInvalidation(Handle<PropertyCell> cell, 17258 void PropertyCell::SetValueWithInvalidation(Handle<PropertyCell> cell,
17259 Handle<Object> new_value) { 17259 Handle<Object> new_value) {
17260 if (cell->value() != *new_value) { 17260 if (cell->value() != *new_value) {
17261 cell->set_value(*new_value); 17261 cell->set_value(*new_value);
17262 Isolate* isolate = cell->GetIsolate(); 17262 Isolate* isolate = cell->GetIsolate();
17263 cell->dependent_code()->DeoptimizeDependentCodeGroup( 17263 cell->dependent_code()->DeoptimizeDependentCodeGroup(
17264 isolate, DependentCode::kPropertyCellChangedGroup); 17264 isolate, DependentCode::kPropertyCellChangedGroup);
17265 } 17265 }
17266 } 17266 }
17267 } } // namespace v8::internal 17267 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « include/v8-version.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698