Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 1232073004: Add suppressions for SVG lighting image filters (Closed)

Created:
5 years, 5 months ago by robertphillips
Modified:
5 years, 5 months ago
Reviewers:
f(malita), reed1
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add suppressions for SVG lighting image filters The Skia CL https://codereview.chromium.org/1229693009/ (Add new SkPoint3 class) causes small images diffs in all the SVG lighting filter layout tests. These suppressions need to be landed before the Skia DEPS roll can land. BUG=509013 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198806

Patch Set 1 #

Patch Set 2 : update to ToT #

Patch Set 3 : update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 2 2 chunks +82 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
robertphillips
5 years, 5 months ago (2015-07-10 18:30:26 UTC) #2
reed1
lgtm
5 years, 5 months ago (2015-07-10 18:34:41 UTC) #3
f(malita)
lgtm
5 years, 5 months ago (2015-07-10 18:35:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232073004/1
5 years, 5 months ago (2015-07-13 13:51:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/37599)
5 years, 5 months ago (2015-07-13 13:57:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232073004/20001
5 years, 5 months ago (2015-07-13 17:56:19 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/37624)
5 years, 5 months ago (2015-07-13 18:03:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232073004/40001
5 years, 5 months ago (2015-07-13 18:30:55 UTC) #16
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 19:55:58 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198806

Powered by Google App Engine
This is Rietveld 408576698