Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1232073003: First steps for creating build/install-build-deps.py (Closed)

Created:
5 years, 5 months ago by Paweł Hajdan Jr.
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

First steps for creating build/install-build-deps.py Supports just --quick-check for now. BUG=508895 R=jochen@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/2d99f9f5081bcb45a65051b669c689ab673a0200

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+430 lines, -0 lines) Patch
A build/install-build-deps.py View 1 chunk +430 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paweł Hajdan Jr.
See bug for context, but I'm happy to explain more if you'd like. I intend ...
5 years, 5 months ago (2015-07-10 15:27:02 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-13 08:55:09 UTC) #3
Paweł Hajdan Jr.
Committed patchset #1 (id:1) manually as 2d99f9f5081bcb45a65051b669c689ab673a0200 (presubmit successful).
5 years, 5 months ago (2015-07-13 09:54:00 UTC) #4
kjellander_chromium
5 years ago (2015-12-02 10:29:23 UTC) #5
Message was sent while issue was closed.
On 2015/07/13 09:54:00, Paweł Hajdan Jr. wrote:
> Committed patchset #1 (id:1) manually as
> 2d99f9f5081bcb45a65051b669c689ab673a0200 (presubmit successful).

I totally support getting rid of the shell script (although with the recent
switch over to using a sysroot image the need of the script is no longer as big,
I guess?).

However, a member of our team today ran into a compilation error due to the
recently added libffi-dev library being missing. She accidentally ran this
script instead of the .sh version, thinking it would fix it (but obviously it
didn't).
Can we either move this script to another location during development, to avoid
confusion, or at least add a large warning when you run the script?

Powered by Google App Engine
This is Rietveld 408576698