Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: sky/tests/widgets/syncs1.dart

Issue 1232063006: Remove "RenderBlock" class from examples that use it without giving it unrestricted height. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/tests/raw/render_flex-expected.txt ('k') | sky/tests/widgets/syncs1-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tests/widgets/syncs1.dart
diff --git a/sky/tests/widgets/syncs1.dart b/sky/tests/widgets/syncs1.dart
index 0fa9991193a316cd9f7e3846c0d2b6b5a7676fac..dcc20355dd57479dba4cffcfc67cc556348a061c 100644
--- a/sky/tests/widgets/syncs1.dart
+++ b/sky/tests/widgets/syncs1.dart
@@ -64,18 +64,21 @@ class FiddleApp extends App {
}
Widget build() {
- return new Block([
- new SizedBox(
- key: 'flex-example',
- height: 250.0,
- child: arbitrarySetting ? buildFlex1() : buildFlex2()
- ),
- new SizedBox(
- key: 'stack-example',
- height: 250.0,
- child: arbitrarySetting ? buildStack1() : buildStack2()
- )
- ]);
+ return new Flex([
+ new SizedBox(
+ key: 'flex-example',
+ height: 250.0,
+ child: arbitrarySetting ? buildFlex1() : buildFlex2()
+ ),
+ new SizedBox(
+ key: 'stack-example',
+ height: 250.0,
+ child: arbitrarySetting ? buildStack1() : buildStack2()
+ )
+ ],
+ direction: FlexDirection.vertical,
+ alignItems: FlexAlignItems.stretch
+ );
}
}
« no previous file with comments | « sky/tests/raw/render_flex-expected.txt ('k') | sky/tests/widgets/syncs1-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698