Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: sky/sdk/example/rendering/baseline.dart

Issue 1232063006: Remove "RenderBlock" class from examples that use it without giving it unrestricted height. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/sdk/example/rendering/flex.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/example/rendering/baseline.dart
diff --git a/sky/sdk/example/rendering/baseline.dart b/sky/sdk/example/rendering/baseline.dart
index 303972c8d7f584460f6de7eb3a7bbaae240fcb81..daf1e83defea50c56a576f70d76f1e0c30266ada 100644
--- a/sky/sdk/example/rendering/baseline.dart
+++ b/sky/sdk/example/rendering/baseline.dart
@@ -5,8 +5,8 @@
import 'dart:sky' as sky;
import 'package:sky/painting/text_style.dart';
-import 'package:sky/rendering/block.dart';
import 'package:sky/rendering/box.dart';
+import 'package:sky/rendering/flex.dart';
import 'package:sky/rendering/object.dart';
import 'package:sky/rendering/paragraph.dart';
import 'package:sky/rendering/sky_binding.dart';
@@ -67,12 +67,15 @@ RenderBox getBox(double lh) {
}
void main() {
- RenderBox root = new RenderBlock(children: [
- new RenderConstrainedBox(
- additionalConstraints: new BoxConstraints.tightFor(height: 50.0)
- ),
- getBox(1.0),
- getBox(null),
- ]);
+ RenderBox root = new RenderFlex(children: [
+ new RenderConstrainedBox(
+ additionalConstraints: new BoxConstraints.tightFor(height: 50.0)
+ ),
+ getBox(1.0),
+ getBox(null),
+ ],
+ direction: FlexDirection.vertical,
+ alignItems: FlexAlignItems.stretch
+ );
new SkyBinding(root: root);
}
« no previous file with comments | « no previous file | sky/sdk/example/rendering/flex.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698