Issue 1232063006: Remove "RenderBlock" class from examples that use it without giving it unrestricted height.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1232063006: Remove "RenderBlock" class from examples that use it without giving it unrestricted height. (Closed)

Created:
5 years, 5 months ago by Hixie

Modified:
5 years, 5 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -139 lines)			Patch
M	sky/sdk/example/rendering/baseline.dart	View		2 chunks	+11 lines, -8 lines	0 comments	Download
A	sky/sdk/example/rendering/flex.dart	View		1 chunk	+93 lines, -0 lines	0 comments	Download
M	sky/tests/raw/box_layout.dart	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	sky/tests/raw/box_layout-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/tests/raw/render_flex.dart	View	1	1 chunk	+2 lines, -88 lines	0 comments	Download
M	sky/tests/raw/render_flex-expected.txt	View	1	1 chunk	+13 lines, -21 lines	0 comments	Download
M	sky/tests/widgets/syncs1.dart	View		1 chunk	+15 lines, -12 lines	0 comments	Download
M	sky/tests/widgets/syncs1-expected.txt	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 5 months ago (2015-07-10 23:31:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
80f5255bb9ca069a7b7801ec96fd8c93acdc9987 (presubmit successful).