Issue 1232033002: clang/win: Add back -Wno-unused-private-field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1232033002: clang/win: Add back -Wno-unused-private-field. (Closed)

Created:
5 years, 5 months ago by Nico

Modified:
5 years, 5 months ago

Reviewers:
benwells

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

clang/win: Add back -Wno-unused-private-field. The world isn't ready for this yet, see bug. This reverts parts of https://codereview.chromium.org/1215643003/ BUG=505317 TBR=benwells@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/e04cb993b677648cb79889cbcd5b228cfd091f34

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	build/common.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	build/config/compiler/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

(on 64-bit bots too: http://build.chromium.org/p/chromium.fyi/builders/ClangToTWin64/builds/1642/steps/compile/logs/stdio On bots not doing official builds too: http://build.chromium.org/p/chromium.fyi/builders/ClangToTWin64%28dbg%29/builds/1274/steps/compile/logs/stdio)

5 years, 5 months ago (2015-07-10 02:55:04 UTC) #1

Nico

5 years, 5 months ago (2015-07-10 02:57:30 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e04cb993b677648cb79889cbcd5b228cfd091f34 (presubmit successful).

Expand Messages | Collapse Messages