Issue 507301: gclient doesn't work on a path with space characters

Fix gclient to work on a path containing space characters

Patch contributed by Leung Wing Chung <lwchkg@gmail.com>;.
Committed on his behalf due to Commit Queue's mishandling of
CRLF files.

Here is my procedure for testing for a new install

1. Download and unzip
   https://src.chromium.org/svn/trunk/tools/depot_tools.zip
   Note that the path should include a space character,
   e.g. "with a space"

2. Copy the three modified files to the unzipped folder

3. Convert the unzipped files into Windows CRLF.

4. REMOVE the following lines from update_depot_tools.bat
   (Should I file a separate bug for this?)

:: Initialize/update virtualenv.
cd /d "%DEPOT_TOOLS_DIR%."
python -u bootstrap\bootstrap.py --deps_file bootstrap\deps.pyl --quiet ENV
if errorlevel 1 goto :EOF

5. Run gclient. Installation should be okay until
   "git rebase" is run.

R=maruel@chromium.org
BUG=507301
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=296275

[lwchkg, 2015-07-10 11:56:53]

lwchkg@gmail.com changed reviewers:
+ iannucci@chromium.org, maruel@chromium.org, szager@chromium.org

[lwchkg, 2015-07-10 11:57:52]

Dear all,

  To fix the issue, I have updated a few punctuations on the committed files.
Please review. (Blame has shown that you three are the owners.)

  Thank you.

Regards,
WC Leung.

[lwchkg, 2015-07-14 12:56:08]

Dear all,

   I have emailed you several days ago but there is still no one reviewing the
code.

   So I am emailing you again for code review. Thanks a lot.

Regards,
WC Leung.

[M-A Ruel, 2015-07-14 13:04:50]

On 2015/07/14 12:56:08, lwchkg wrote:
> Dear all,
> 
>    I have emailed you several days ago but there is still no one reviewing the
> code.
> 
>    So I am emailing you again for code review. Thanks a lot.
> 
> Regards,
> WC Leung.

Hi

I was travelling in the past 4 days which explains the delay.

As for the change, I don't mind this change but as for the possibility to
support whitespace in a chromium checkout, there's close to 0% of chance to
succeed. It's just not worth the trouble. I'll have to try the patch myself
locally, which I'll likely not have time to do until tomorrow, will report back.

Thanks

[lwchkg, 2015-07-30 17:08:33]

Ping for a week of inactivity.

WC Leung.

[M-A Ruel, 2015-08-10 19:37:26]

On 2015/07/30 17:08:33, lwchkg wrote:
> Ping for a week of inactivity.

Back from vacation, will manually try this patch tomorrow.

[M-A Ruel, 2015-08-12 14:10:34]

On 2015/08/10 19:37:26, M-A Ruel wrote:
> On 2015/07/30 17:08:33, lwchkg wrote:
> > Ping for a week of inactivity.
> 
> Back from vacation, will manually try this patch tomorrow.

Confirmed it doesn't break anything. Committing manually due to the CQ not
handling CRLF files properly.

[M-A Ruel, 2015-08-12 14:14:01]

lgtm

[M-A Ruel, 2015-08-12 14:24:42]

Committed patchset #1 (id:1) manually as 296275 (presubmit successful).

[lwchkg, 2015-08-12 17:23:58]

On 2015/08/12 14:24:42, M-A Ruel wrote:
> Committed patchset #1 (id:1) manually as 296275 (presubmit successful).

Thanks a lot for the review.