Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: runtime/vm/raw_object_snapshot.cc

Issue 12320103: Fix for bug 6767 - Limit stack trace collection for stack overflow exceptions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object_store.cc ('k') | runtime/vm/snapshot.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object_snapshot.cc
===================================================================
--- runtime/vm/raw_object_snapshot.cc (revision 19067)
+++ runtime/vm/raw_object_snapshot.cc (working copy)
@@ -2387,7 +2387,24 @@
intptr_t object_id,
intptr_t tags,
Snapshot::Kind kind) {
- UNIMPLEMENTED();
+ if (kind == Snapshot::kFull) {
+ Stacktrace& result = Stacktrace::ZoneHandle(reader->isolate(),
+ reader->NewStacktrace());
+ reader->AddBackRef(object_id, &result, kIsDeserialized);
+
+ // There are no non object pointer fields.
+
+ // Read all the object pointer fields.
+ Array& array = Array::Handle(reader->isolate());
+ array ^= reader->ReadObjectRef();
+ result.set_function_array(array);
+ array ^= reader->ReadObjectRef();
+ result.set_code_array(array);
+ array ^= reader->ReadObjectRef();
+ result.set_pc_offset_array(array);
+ return result.raw();
+ }
+ UNREACHABLE(); // Stacktraces are not sent in a snapshot.
return Stacktrace::null();
}
@@ -2395,7 +2412,26 @@
void RawStacktrace::WriteTo(SnapshotWriter* writer,
intptr_t object_id,
Snapshot::Kind kind) {
- UNIMPLEMENTED();
+ if (kind == Snapshot::kFull) {
+ ASSERT(writer != NULL);
+ ASSERT(this == Isolate::Current()->object_store()->
+ preallocated_stack_trace());
+
+ // Write out the serialization header value for this object.
+ writer->WriteInlinedObjectHeader(object_id);
+
+ // Write out the class and tags information.
+ writer->WriteIndexedObject(kStacktraceCid);
+ writer->WriteIntptrValue(writer->GetObjectTags(this));
+
+ // There are no non object pointer fields.
+
+ // Write out all the object pointer fields.
+ SnapshotWriterVisitor visitor(writer);
+ visitor.VisitPointers(from(), to());
+ } else {
+ UNREACHABLE(); // Stacktraces are not supported for other snapshot forms.
+ }
}
« no previous file with comments | « runtime/vm/object_store.cc ('k') | runtime/vm/snapshot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698