Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: runtime/vm/object.h

Issue 12320103: Fix for bug 6767 - Limit stack trace collection for stack overflow exceptions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/exceptions.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h (revision 19067)
+++ runtime/vm/object.h (working copy)
@@ -6286,20 +6286,29 @@
// Internal stacktrace object used in exceptions for printing stack traces.
class Stacktrace : public Instance {
public:
+ static const int kPreallocatedStackdepth = 10;
+
intptr_t Length() const;
+
RawFunction* FunctionAtFrame(intptr_t frame_index) const;
+ void SetFunctionAtFrame(intptr_t frame_index, const Function& func) const;
+
RawCode* CodeAtFrame(intptr_t frame_index) const;
+ void SetCodeAtFrame(intptr_t frame_index, const Code& code) const;
+
RawSmi* PcOffsetAtFrame(intptr_t frame_index) const;
- void Append(const GrowableObjectArray& func_list,
- const GrowableObjectArray& code_list,
- const GrowableObjectArray& pc_offset_list) const;
+ void SetPcOffsetAtFrame(intptr_t frame_index, const Smi& pc_offset) const;
+ void Append(const Array& func_list,
+ const Array& code_list,
+ const Array& pc_offset_list) const;
+
static intptr_t InstanceSize() {
return RoundedAllocationSize(sizeof(RawStacktrace));
}
- static RawStacktrace* New(const GrowableObjectArray& func_list,
- const GrowableObjectArray& code_list,
- const GrowableObjectArray& pc_offset_list,
+ static RawStacktrace* New(const Array& func_array,
+ const Array& code_array,
+ const Array& pc_offset_array,
Heap::Space space = Heap::kNew);
const char* ToCStringInternal(bool verbose) const;
« no previous file with comments | « runtime/vm/exceptions.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698