dart:io: Prevent initial WRITE event on RawSecureSocket when writeEventsEnabled is set to false.

sdk/lib/io/secure_socket.dart

Index: sdk/lib/io/secure_socket.dart
diff --git a/sdk/lib/io/secure_socket.dart b/sdk/lib/io/secure_socket.dart
index 333edd12b3532b572275ed0767e32a52647880b1..c1f40db91ed87817ace2ad5633e1ae8b445d4660 100644
--- a/sdk/lib/io/secure_socket.dart
+++ b/sdk/lib/io/secure_socket.dart
@@ -386,6 +386,7 @@ class _RawSecureSocket extends Stream<RawSocketEvent>
 
   void set writeEventsEnabled(bool value) {
     if (value &&
+        _controller.hasSubscribers &&

[Søren Gjesse, 2013/02/25 07:20:44]

What about paused?

[Bill Hesse, 2013/02/25 07:32:36]

It should be legal to enqueue a WRITE event if they are enabled while the
subscription is paused.  The main thing is to stop events being queued before
the first .listen.

Since we only send an initial WRITE event on a .listen call when they are
enabled, not on a pauseChange, we cannot handle the case that a WRITE event from
the base socket comes during a pause, unless we enqueue it at the time it
arrives.

[Søren Gjesse, 2013/02/25 14:50:54]

I agree that it is not an error to send WRITE events when paused. However I
still think we should avoid doing that so that we handle pause/resume and only
send events when not paused.

When unpausing shouldn't just send a WRITE event if there is room in the
plaintext write buffer?

         _secureFilter != null &&
         _secureFilter.buffers[WRITE_PLAINTEXT].free > 0) {
       new Timer(0, (_) => _controller.add(RawSocketEvent.WRITE));
@@ -489,6 +490,7 @@ class _RawSecureSocket extends Stream<RawSocketEvent>
         _secureHandshake();
       } catch (e) { _reportError(e, "RawSecureSocket error"); }
     } else if (_status == CONNECTED &&
+               _controller.hasSubscribers &&

[Søren Gjesse, 2013/02/25 07:20:44]

Ditto.

                _writeEventsEnabled &&
                _secureFilter.buffers[WRITE_PLAINTEXT].free > 0) {
       // Reset the one-shot handler.